linux-next: build failure after final merge (net tree)

linux-next: build failure after final merge (net tree)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Hi Dave,

After merging the scsi-post-merge tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/greth.c: In function 'greth_of_probe':
drivers/net/greth.c:1414: error: implicit declaration of function 'of_ioremap'
drivers/net/greth.c:1414: error: 'struct of_device' has no member named 'resource'
drivers/net/greth.c:1415: error: 'struct of_device' has no member named 'resource'
drivers/net/greth.c:1426: error: 'struct of_device' has no member named 'irqs'
drivers/net/greth.c:1580: error: implicit declaration of function 'of_iounmap'
drivers/net/greth.c:1580: error: 'struct of_device' has no member named 'resource'
drivers/net/greth.c:1580: error: 'struct of_device' has no member named 'resource'
drivers/net/greth.c: In function 'greth_of_remove':
drivers/net/greth.c:1605: error: 'struct of_device' has no member named 'resource'
drivers/net/greth.c:1605: error: 'struct of_device' has no member named 'resource'

Caused by commit d4c41139df6e74c6fff0cbac43e51cab782133be ("net: Add
Aeroflex Gaisler 10/100/1G Ethernet MAC driver").

I assume that this driver was written and tested only on Sparc ... maybe
it should depend on SPARC?

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after final merge (net tree)

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 19 Feb 2010 17:37:13 +1100

> I assume that this driver was written and tested only on Sparc ... maybe
> it should depend on SPARC?
> 
> I have reverted that commit for today.

I'll take a look at what it really depends upon.

Thanks.

Re: linux-next: build failure after final merge (net tree)

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 19 Feb 2010 17:37:13 +1100

> I assume that this driver was written and tested only on Sparc
> ... maybe it should depend on SPARC?

Indeed, it should.  I thought for some reason that all OF
platforms have of_remap() and of_device->resource[], oh
well :-)

Will commit the following, thanks!

net: Make GRETH driver depend on SPARC.

Reported by Stephen Rothwell.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 17ff15f..46af867 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -997,7 +997,7 @@ config ETHOC
 
 config GRETH
 	tristate "Aeroflex Gaisler GRETH Ethernet MAC support"
-	depends on OF
+	depends on SPARC
 	select PHYLIB
 	select CRC32
 	help
-- 
1.6.6.1

Re: linux-next: build failure after final merge (net tree)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi Dave,

On Thu, 18 Feb 2010 23:33:21 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 19 Feb 2010 17:37:13 +1100
> 
> > I assume that this driver was written and tested only on Sparc
> > ... maybe it should depend on SPARC?
> 
> Indeed, it should.  I thought for some reason that all OF
> platforms have of_remap() and of_device->resource[], oh
> well :-)
> 
> Will commit the following, thanks!
> 
> net: Make GRETH driver depend on SPARC.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build failure after final merge (net tree)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi Dave,

After merging, today's linux-next build (sparc64 defconfig) failed like
this:

In file included from include/linux/netfilter_ipv4/ip_tables.h:29,
                 from arch/sparc/kernel/sys_sparc32.c:47:
include/linux/netfilter/x_tables.h:525: error: expected declaration specifiers or '...' before 'nf_hookfn'

Caused by commit 2b95efe7f6bb750256a702cc32d33b0cb2cd8223 ("netfilter:
xtables: use xt_table for hook instantiation").  Missing direct include
of linux/netfilter.h?

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after final merge (net tree)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On Wed, 17 Feb 2010 17:40:15 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Caused by commit 2b95efe7f6bb750256a702cc32d33b0cb2cd8223 ("netfilter:
> xtables: use xt_table for hook instantiation").  Missing direct include
> of linux/netfilter.h?

The address for Jan Engelhardt is bouncing ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after final merge (net tree)

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 17 Feb 2010 17:40:15 +1100

> After merging, today's linux-next build (sparc64 defconfig) failed like
> this:

Fixed for at least 6 hours:

From 177867ce08f2756fa361e37086fc1792d7b4cf29 Mon Sep 17 00:00:00 2001
From: David S. Miller <davem@davemloft.net>
Date: Tue, 16 Feb 2010 15:23:23 -0800
Subject: [PATCH 641/698] sparc64: Kill bogus ip_tables.h include.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes the following build failure:

  CC      arch/sparc/kernel/sys_sparc32.o
In file included from include/linux/netfilter_ipv4/ip_tables.h:28,
                 from arch/sparc/kernel/sys_sparc32.c:46:
include/linux/netfilter/x_tables.h:525: error: expected declaration specifiers or ‘...’ before ‘nf_hookfn’

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/kernel/sys_sparc32.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/kernel/sys_sparc32.c b/arch/sparc/kernel/sys_sparc32.c
index dc0ac19..daded3b 100644
--- a/arch/sparc/kernel/sys_sparc32.c
+++ b/arch/sparc/kernel/sys_sparc32.c
@@ -43,7 +43,6 @@
 #include <linux/security.h>
 #include <linux/compat.h>
 #include <linux/vfs.h>
-#include <linux/netfilter_ipv4/ip_tables.h>
 #include <linux/ptrace.h>
 
 #include <asm/types.h>
-- 
1.6.6.1

Re: linux-next: build failure after final merge (net tree)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

On Tue, 16 Feb 2010 23:11:09 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 17 Feb 2010 17:40:15 +1100
> 
> > After merging, today's linux-next build (sparc64 defconfig) failed like
> > this:
> 
> Fixed for at least 6 hours:

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after final merge (net tree)

[Eric Dumazet]

Le mercredi 17 février 2010 à 17:40 +1100, Stephen Rothwell a écrit :
> Hi Dave,
> 
> After merging, today's linux-next build (sparc64 defconfig) failed like
> this:
> 
> In file included from include/linux/netfilter_ipv4/ip_tables.h:29,
>                  from arch/sparc/kernel/sys_sparc32.c:47:
> include/linux/netfilter/x_tables.h:525: error: expected declaration specifiers or '...' before 'nf_hookfn'
> 
> Caused by commit 2b95efe7f6bb750256a702cc32d33b0cb2cd8223 ("netfilter:
> xtables: use xt_table for hook instantiation").  Missing direct include
> of linux/netfilter.h?
> 

Hi Stephen

David took care of this already.

http://marc.info/?l=linux-netdev&m=126636301220734&w=2