Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA
@ 2012-08-31 22:36 Sony Chacko
  2012-08-31 22:36 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
                   ` (12 more replies)
  0 siblings, 13 replies; 17+ messages in thread
From: Sony Chacko @ 2012-08-31 22:36 UTC (permalink / raw)
  To: davem; +Cc: netdev, Dept_NX_Linux_NIC_Driver, Sony Chacko

From: Sony Chacko <sony.chacko@qlogic.com>

>From: David Miller [mailto:davem@davemloft.net]

>Firstly, I'm not going to let you create arbitrary new sysfs
>and debugfs crap for facilities that are already supported by
>the kernel via other interfaces.

>For example, providing a facility to read and write the PCI BARs
>is completely pointless.  Use the PCI config space access APIs for
>this if you want to do this from userspace.

>The patches are also much more verbose than they need to be.
>When you move an operation to the new hwops, keep the existing function
>name but make it an inline function that invokes the hwop.

>That way you won't need hundreds of lines in your patch that look like this:

>-	qlcnic_clear_lb_mode(adapter);
>+	ahw->hw_ops->clear_loopback(adapter, mode);

>Instead you'd have:

>static inline void qlcnic_clear_lb_mode(struct qlcnic_adapter *adapter,
>							u8 mode) {
>	struct qlcnic_hardware_context *ahw = &adapter->ahw;

>	ahw->hw_ops->clear_loopback(adapter, mode); }

>From: David Miller [mailto:davem@davemloft.net] 
>Sent: Friday, August 31, 2012 1:05 PM

> +static inline int
> +qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 
> +rate) {
> +	return adapter->nic_ops->config_led(adapter, state, rate);
> +
> +}
> +

>Please get rid of those unnecessary empty lines in the function bodies.


I have made the changes as you suggested above,
please drop all the previous 12 patches.
We are not creating new sysfs nodes.

Please apply the updated patch series to net-next.

Thanks,
Sony

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA
@ 2012-08-31  6:28 Sony Chacko
  0 siblings, 0 replies; 17+ messages in thread
From: Sony Chacko @ 2012-08-31  6:28 UTC (permalink / raw)
  To: davem; +Cc: netdev, Dept_NX_Linux_NIC_Driver, Sony Chacko

From: Sony Chacko <sony.chacko@qlogic.com>

>From: David Miller [mailto:davem@davemloft.net]

>Firstly, I'm not going to let you create arbitrary new sysfs
>and debugfs crap for facilities that are already supported by
>the kernel via other interfaces.

>For example, providing a facility to read and write the PCI BARs
>is completely pointless.  Use the PCI config space access APIs for
>this if you want to do this from userspace.

>The patches are also much more verbose than they need to be.
>When you move an operation to the new hwops, keep the existing function
>name but make it an inline function that invokes the hwop.

>That way you won't need hundreds of lines in your patch that look like this:

>-	qlcnic_clear_lb_mode(adapter);
>+	ahw->hw_ops->clear_loopback(adapter, mode);

>Instead you'd have:

>static inline void qlcnic_clear_lb_mode(struct qlcnic_adapter *adapter,
>							u8 mode) {
>	struct qlcnic_hardware_context *ahw = &adapter->ahw;

>	ahw->hw_ops->clear_loopback(adapter, mode); }

I have made the changes as you suggested above.
Please apply the updated pacth series to net-next.

Thanks,
Sony

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2012-09-01  1:29 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-31 22:36 [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-08-31 22:36 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-08-31 22:36 ` [PATCH 02/12] qlcnic: Refactoring - Tx/Rx code path separation Sony Chacko
2012-08-31 22:36 ` [PATCH 03/12] qlcnic: Refactoring - Moving hw specific data to hardware context Sony Chacko
2012-08-31 22:36 ` [PATCH 04/12] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-08-31 22:36 ` [PATCH 05/12] qlcnic: change driver firmware interface mechanism Sony Chacko
2012-08-31 22:36 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
2012-08-31 22:36 ` [PATCH 07/12] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-08-31 22:36 ` [PATCH 08/12] qlcnic: 83xx CNA inter driver communication mechanism Sony Chacko
2012-08-31 22:36 ` [PATCH 09/12] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-08-31 22:36 ` [PATCH 10/12] qlcnic: register dump utility Sony Chacko
2012-08-31 22:36 ` [PATCH 11/12] qlcnic: 83xx adpater ethtool Sony Chacko
2012-08-31 22:36 ` [PATCH 12/12] qlcnic: update driver version - 5.1.30 Sony Chacko
2012-09-01  0:00 ` [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA David Miller
2012-09-01  0:53   ` David Miller
2012-09-01  1:29     ` Sony Chacko
  -- strict thread matches above, loose matches on Subject: below --
2012-08-31  6:28 Sony Chacko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox