Netdev List
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Atzm Watanabe <atzm@stratosphere.co.jp>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.
Date: Thu, 11 Apr 2013 08:24:38 -0700	[thread overview]
Message-ID: <20130411082438.7fe3421b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <87li8pmkvh.wl%atzm@stratosphere.co.jp>

On Thu, 11 Apr 2013 19:17:54 +0900
Atzm Watanabe <atzm@stratosphere.co.jp> wrote:

> diff --git a/include/linux/if_link.h b/include/linux/if_link.h
> index 40167af..0bf03dc 100644
> --- a/include/linux/if_link.h
> +++ b/include/linux/if_link.h
> @@ -296,6 +296,7 @@ enum {
>  	IFLA_VXLAN_GROUP,
>  	IFLA_VXLAN_LINK,
>  	IFLA_VXLAN_LOCAL,
> +	IFLA_VXLAN_REMOTE,
>  	IFLA_VXLAN_TTL,
>  	IFLA_VXLAN_TOS,

You can't insert another value into the middle of an enum list.
It changes the kernel-userspace ABI values.

  reply	other threads:[~2013-04-11 15:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 10:17 [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address Atzm Watanabe
2013-04-11 15:24 ` Stephen Hemminger [this message]
2013-04-11 17:30   ` David Miller
2013-04-12  5:31     ` Atzm Watanabe
2013-04-11 17:48 ` Ben Hutchings
2013-04-12  5:31   ` Atzm Watanabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411082438.7fe3421b@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=atzm@stratosphere.co.jp \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox