Netdev List
 help / color / mirror / Atom feed
From: Atzm Watanabe <atzm@stratosphere.co.jp>
To: David Miller <davem@davemloft.net>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.
Date: Fri, 12 Apr 2013 14:31:32 +0900	[thread overview]
Message-ID: <87k3o8mi17.wl%atzm@stratosphere.co.jp> (raw)
In-Reply-To: <20130411.133014.1750297317239802950.davem@davemloft.net>

At Thu, 11 Apr 2013 13:30:14 -0400 (EDT),
David Miller wrote:
> 
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Thu, 11 Apr 2013 08:24:38 -0700
> 
> > On Thu, 11 Apr 2013 19:17:54 +0900
> > Atzm Watanabe <atzm@stratosphere.co.jp> wrote:
> > 
> >> diff --git a/include/linux/if_link.h b/include/linux/if_link.h
> >> index 40167af..0bf03dc 100644
> >> --- a/include/linux/if_link.h
> >> +++ b/include/linux/if_link.h
> >> @@ -296,6 +296,7 @@ enum {
> >>  	IFLA_VXLAN_GROUP,
> >>  	IFLA_VXLAN_LINK,
> >>  	IFLA_VXLAN_LOCAL,
> >> +	IFLA_VXLAN_REMOTE,
> >>  	IFLA_VXLAN_TTL,
> >>  	IFLA_VXLAN_TOS,
> > 
> > You can't insert another value into the middle of an enum list.
> > It changes the kernel-userspace ABI values.
> 
> Right.

Thank you for pointing it out.
I'll move IFLA_VXLAN_REMOTE to the last and resend the patch.

Thanks.

  reply	other threads:[~2013-04-12  5:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 10:17 [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address Atzm Watanabe
2013-04-11 15:24 ` Stephen Hemminger
2013-04-11 17:30   ` David Miller
2013-04-12  5:31     ` Atzm Watanabe [this message]
2013-04-11 17:48 ` Ben Hutchings
2013-04-12  5:31   ` Atzm Watanabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3o8mi17.wl%atzm@stratosphere.co.jp \
    --to=atzm@stratosphere.co.jp \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox