Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.

[Atzm Watanabe <atzm@stratosphere.co.jp>]

At Thu, 11 Apr 2013 18:48:20 +0100,
Ben Hutchings wrote:
> 
> On Thu, 2013-04-11 at 19:17 +0900, Atzm Watanabe wrote:
> > This patch allows setting VXLAN destination to unicast address.
> > It allows that VXLAN can be used as peer-to-peer tunnel without
> > multicast.
> > 
> > v2: use a new argument "remote" instead of "group" based by
> >     Stephen Hemminger's comments.
> > 
> > Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
> [...]
> > --- a/ip/iplink_vxlan.c
> > +++ b/ip/iplink_vxlan.c
> > @@ -23,7 +23,8 @@
> >  
> >  static void explain(void)
> >  {
> > -	fprintf(stderr, "Usage: ... vxlan id VNI [ group ADDR ] [ local ADDR ]\n");
> > +	fprintf(stderr, "Usage: ... vxlan id VNI [ group ADDR ] [ remote ADDR ]\n");
> [...]
> 
> Shouldn't that be "[ group|remote ADDR ]", to show that you can specify
> one or the other?

Yes, basically I agreed.
I think this should be "[ { group | remote } ADDR ]",
to accommodate the notation to others.
I'll fix this and resend the patch.

Thanks.