From: Francois Romieu <romieu@fr.zoreil.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: grant.likely@linaro.org, rob.herring@calxeda.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: question about netif_rx
Date: Sun, 11 Aug 2013 17:56:40 +0200 [thread overview]
Message-ID: <20130811155640.GA10070@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1308111151210.2072@localhost6.localdomain6>
Julia Lawall <julia.lawall@lip6.fr> :
> To my limited understanding, in a NAPI polling function, one should use
> netif_receive_skb, rather than netif_rx.
Nit: or napi_gro_receive (+ napi_gro_flush with __napi_complete) when the
device offers some checksum offloading features.
> However, the via-velocity driver defines the NAPI polling function
> velocity_poll, which is the only caller of velocity_rx_srv, which
> is the only caller of velocity_receive_frame, which calls netif_rx.
> The call to netif_rx seems to predate the introduction of NAPI in
> this driver. Is this correct?
You are right. It's a leftover of the NAPI changes in this driver.
Can you send a netif_receive_skb replacement patch for it ?
--
Ueimor
next prev parent reply other threads:[~2013-08-11 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 9:56 question about netif_rx Julia Lawall
2013-08-11 15:56 ` Francois Romieu [this message]
2013-08-11 16:12 ` Julia Lawall
2013-08-13 5:20 ` Francois Romieu
2013-08-13 5:45 ` David Shwatrz
2013-08-13 6:28 ` Francois Romieu
2013-08-13 6:29 ` Julia Lawall
2013-08-13 6:53 ` David Shwatrz
2013-08-13 20:41 ` Francois Romieu
2013-08-14 10:44 ` Rami Rosen
2013-08-14 15:18 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130811155640.GA10070@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox