From: Julia Lawall <julia.lawall@lip6.fr>
To: Rami Rosen <roszenrami@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
David Shwatrz <dshwatrz@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>,
grant.likely@linaro.org, rob.herring@calxeda.com,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: question about netif_rx
Date: Wed, 14 Aug 2013 17:18:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1308141713290.2257@hadrien> (raw)
In-Reply-To: <CAKoUAr==Ex=XAJe4=4R+BY5QaNXKMjM4EsHYbppbXOyROi2NAw@mail.gmail.com>
On Wed, 14 Aug 2013, Rami Rosen wrote:
> Hi,
> BTW, this is not the only NAPI issue here. When looking into cleanup
> of resources in this driver, a call to netif_napi_del() is missing
> (though there is a call to napi_disable(), which is not enough for
> proper cleanup).
Actually, netif_napi_del seems to be quite underused. At least
approximately, I would assume that every file that uses netif_napi_add
should use netif_napi_del at least once, and possible more times. But I
find 118 .c files that use netif_napi_add, and only 35 that use
netif_napi_del.
Are there some cases where it might not be needed?
julia
prev parent reply other threads:[~2013-08-14 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 9:56 question about netif_rx Julia Lawall
2013-08-11 15:56 ` Francois Romieu
2013-08-11 16:12 ` Julia Lawall
2013-08-13 5:20 ` Francois Romieu
2013-08-13 5:45 ` David Shwatrz
2013-08-13 6:28 ` Francois Romieu
2013-08-13 6:29 ` Julia Lawall
2013-08-13 6:53 ` David Shwatrz
2013-08-13 20:41 ` Francois Romieu
2013-08-14 10:44 ` Rami Rosen
2013-08-14 15:18 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1308141713290.2257@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devicetree@vger.kernel.org \
--cc=dshwatrz@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=romieu@fr.zoreil.com \
--cc=roszenrami@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox