From: Francois Romieu <romieu@fr.zoreil.com>
To: David Shwatrz <dshwatrz@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
grant.likely@linaro.org, rob.herring@calxeda.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: question about netif_rx
Date: Tue, 13 Aug 2013 22:41:31 +0200 [thread overview]
Message-ID: <20130813204131.GA4696@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <CAJJAcocQ59Kc9a1b=jrNSc1akLLN_74yKANMEmLVmvxoRjX4hw@mail.gmail.com>
(no top-post nor lazy quote please)
David Shwatrz <dshwatrz@gmail.com> :
[...]
> In the napi_gro_receive() we check that the device supports
> NETIF_F_GRO, but I don't see that we inspect checksum or that
> NETIF_F_GRO is depends on checksum.
napi_gro_receive is irrelevant. Let aside tunnel, the real work happens
in the protocol specific gro_receive handlers.
However I am an happy retard and I missed that tcp gro stopped depending
on Rx checksum since commit 861b650101eb0c627d171eb18de81dddb93d395e. :o/
So, yes, napi_gro_receive could be used.
--
Ueimor
next prev parent reply other threads:[~2013-08-13 20:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 9:56 question about netif_rx Julia Lawall
2013-08-11 15:56 ` Francois Romieu
2013-08-11 16:12 ` Julia Lawall
2013-08-13 5:20 ` Francois Romieu
2013-08-13 5:45 ` David Shwatrz
2013-08-13 6:28 ` Francois Romieu
2013-08-13 6:29 ` Julia Lawall
2013-08-13 6:53 ` David Shwatrz
2013-08-13 20:41 ` Francois Romieu [this message]
2013-08-14 10:44 ` Rami Rosen
2013-08-14 15:18 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813204131.GA4696@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=devicetree@vger.kernel.org \
--cc=dshwatrz@gmail.com \
--cc=grant.likely@linaro.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox