From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org, roland@purestorage.com
Subject: Re: arp_hash
Date: Sun, 22 Mar 2015 12:54:58 -0400 (EDT) [thread overview]
Message-ID: <20150322.125458.2054837991708165397.davem@davemloft.net> (raw)
In-Reply-To: <20150322114204.GA5010@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 22 Mar 2015 22:42:04 +1100
> If the attacker can somehow get the pointer value of the device
> then all is lost since they could set any number of the low bits
> of val to zero.
This "attacker" with access to your physcial network?
I'm all for shifting the device pointer down a few bits to get more
entropy, but I don't completely agree with the rest of your
objections.
This hash function has to be as fast as possible, even jhash{,2} is
too expensive.
next prev parent reply other threads:[~2015-03-22 16:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 11:42 arp_hash Herbert Xu
2015-03-22 12:56 ` arp_hash Eric Dumazet
2015-03-22 16:57 ` arp_hash David Miller
2015-03-22 21:21 ` arp_hash Herbert Xu
2015-03-22 21:56 ` arp_hash Herbert Xu
2015-03-22 22:51 ` arp_hash Herbert Xu
2015-03-22 23:22 ` arp_hash Herbert Xu
2015-03-22 23:35 ` arp_hash Herbert Xu
2015-03-23 10:58 ` arp_hash Herbert Xu
2015-03-22 22:58 ` arp_hash David Miller
2015-03-22 23:08 ` arp_hash Herbert Xu
2015-03-22 23:50 ` arp_hash David Miller
2015-03-22 23:53 ` arp_hash Herbert Xu
2015-03-22 16:54 ` David Miller [this message]
2015-03-22 21:34 ` arp_hash Herbert Xu
2015-03-22 22:57 ` arp_hash David Miller
2015-03-22 23:42 ` arp_hash Herbert Xu
2015-03-22 23:53 ` arp_hash David Miller
2015-03-23 11:01 ` arp_hash Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322.125458.2054837991708165397.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox