Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, roland@purestorage.com
Subject: Re: arp_hash
Date: Sun, 22 Mar 2015 19:50:03 -0400 (EDT)	[thread overview]
Message-ID: <20150322.195003.654000183854114521.davem@davemloft.net> (raw)
In-Reply-To: <20150322230848.GA8989@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 23 Mar 2015 10:08:48 +1100

> On Sun, Mar 22, 2015 at 06:58:50PM -0400, David Miller wrote:
>>
>> But I do not agree with the idea that it is in any way possible to
>> stop someone with root access on the physical network from crudding up
>> our ARP hash tables.
> 
> But you don't need root access to exploit the neighbour hash
> table.  You just need a sufficiently large (e.g., /16) route
> to a network and anybody on the system can then generate traffic
> to it.
> 
> Granted these days hardly anybody on IPv4 would have such a route
> but if you do then the hash table makes you exposed.
> 
> And for IPv6 everybody is potentially exposed.

BTW I asked for feedback when I posted the patches which created this
situation, and the multiply with the random input was believed to have
sufficient entropy and not create a situation any worse,
asymptotically, than what we had beforehand.

Perhaps the ipv6 case can be improved, by using a u32 random input
for each u32 of the address being hashed.

  reply	other threads:[~2015-03-22 23:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 11:42 arp_hash Herbert Xu
2015-03-22 12:56 ` arp_hash Eric Dumazet
2015-03-22 16:57   ` arp_hash David Miller
2015-03-22 21:21   ` arp_hash Herbert Xu
2015-03-22 21:56   ` arp_hash Herbert Xu
2015-03-22 22:51     ` arp_hash Herbert Xu
2015-03-22 23:22       ` arp_hash Herbert Xu
2015-03-22 23:35         ` arp_hash Herbert Xu
2015-03-23 10:58           ` arp_hash Herbert Xu
2015-03-22 22:58     ` arp_hash David Miller
2015-03-22 23:08       ` arp_hash Herbert Xu
2015-03-22 23:50         ` David Miller [this message]
2015-03-22 23:53           ` arp_hash Herbert Xu
2015-03-22 16:54 ` arp_hash David Miller
2015-03-22 21:34   ` arp_hash Herbert Xu
2015-03-22 22:57     ` arp_hash David Miller
2015-03-22 23:42       ` arp_hash Herbert Xu
2015-03-22 23:53         ` arp_hash David Miller
2015-03-23 11:01           ` arp_hash Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150322.195003.654000183854114521.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=roland@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox