Re: arp_hash

[Herbert Xu <herbert@gondor.apana.org.au>]

On Mon, Mar 23, 2015 at 08:56:12AM +1100, Herbert Xu wrote:
> On Sun, Mar 22, 2015 at 05:56:21AM -0700, Eric Dumazet wrote:
> > On Sun, 2015-03-22 at 22:42 +1100, Herbert Xu wrote:
> > > 
> > > While googling I found the 2011 discussion on changing the arp_hash
> > > function.  I must say that I'm not really impressed by the new
> > > function that replaced jhash :)
> > > 
> > > 	u32 key = *(const u32 *)pkey;
> > > 	u32 val = key ^ hash32_ptr(dev);
> > > 
> > > 	return val * hash_rnd[0];
> 
> In fact this function is worse than I thought.  Because the IP

OK I'm wrong because net/core/neighbour.c uses only the high-order
bits of the hash.

Sorry for the noise.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt