* [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu
@ 2016-12-15 9:53 Daniel Mack
2016-12-16 18:20 ` Alexei Starovoitov
2016-12-17 16:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Mack @ 2016-12-15 9:53 UTC (permalink / raw)
To: ast; +Cc: daniel, netdev, davem, Daniel Mack
The member 'effective' in 'struct cgroup_bpf' is protected by RCU.
Annotate it accordingly to squelch a sparse warning.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
include/linux/bpf-cgroup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
index 7b6e5d1..92bc89a 100644
--- a/include/linux/bpf-cgroup.h
+++ b/include/linux/bpf-cgroup.h
@@ -20,7 +20,7 @@ struct cgroup_bpf {
* when this cgroup is accessed.
*/
struct bpf_prog *prog[MAX_BPF_ATTACH_TYPE];
- struct bpf_prog *effective[MAX_BPF_ATTACH_TYPE];
+ struct bpf_prog __rcu *effective[MAX_BPF_ATTACH_TYPE];
};
void cgroup_bpf_put(struct cgroup *cgrp);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu
2016-12-15 9:53 [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu Daniel Mack
@ 2016-12-16 18:20 ` Alexei Starovoitov
2016-12-17 16:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2016-12-16 18:20 UTC (permalink / raw)
To: Daniel Mack; +Cc: ast, daniel, netdev, davem
On Thu, Dec 15, 2016 at 10:53:21AM +0100, Daniel Mack wrote:
> The member 'effective' in 'struct cgroup_bpf' is protected by RCU.
> Annotate it accordingly to squelch a sparse warning.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
was only wondering whether this is really needed for net or can wait till net-next.
> ---
> include/linux/bpf-cgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
> index 7b6e5d1..92bc89a 100644
> --- a/include/linux/bpf-cgroup.h
> +++ b/include/linux/bpf-cgroup.h
> @@ -20,7 +20,7 @@ struct cgroup_bpf {
> * when this cgroup is accessed.
> */
> struct bpf_prog *prog[MAX_BPF_ATTACH_TYPE];
> - struct bpf_prog *effective[MAX_BPF_ATTACH_TYPE];
> + struct bpf_prog __rcu *effective[MAX_BPF_ATTACH_TYPE];
> };
>
> void cgroup_bpf_put(struct cgroup *cgrp);
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu
2016-12-15 9:53 [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu Daniel Mack
2016-12-16 18:20 ` Alexei Starovoitov
@ 2016-12-17 16:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-17 16:14 UTC (permalink / raw)
To: daniel; +Cc: ast, daniel, netdev
From: Daniel Mack <daniel@zonque.org>
Date: Thu, 15 Dec 2016 10:53:21 +0100
> The member 'effective' in 'struct cgroup_bpf' is protected by RCU.
> Annotate it accordingly to squelch a sparse warning.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-17 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-15 9:53 [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu Daniel Mack
2016-12-16 18:20 ` Alexei Starovoitov
2016-12-17 16:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox