public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Harald Welte <laforge@gnumonks.org>
To: Tom Herbert <tom@quantonium.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pablo@netfilter.org,
	rohit@quantonium.net
Subject: Re: [PATCH net-next 05/14] gtp: Remove special mtu handling
Date: Tue, 19 Sep 2017 19:42:05 +0800	[thread overview]
Message-ID: <20170919114205.z2txj6rwo2row7u4@nataraja> (raw)
In-Reply-To: <20170919003904.5124-6-tom@quantonium.net>

Hi Tom,

On Mon, Sep 18, 2017 at 05:38:55PM -0700, Tom Herbert wrote:
> Removes MTU handling in gtp_build_skb_ip4. This is non standard relative
> to how other tunneling protocols handle MTU. The model espoused is that
> the inner interface should set it's MTU to be less than the expected
> path MTU on the overlay network. Path MTU discovery is not typically
> used for modifying tunnel MTUs.

The point of the kernel GTP module is to interoperate with existing
other GTP implementations and the practises established by cellular
operators when operating GTP in their networks.

While what you describe (chose interface MTU to be less than the
expected path MTU) is generally best practise in the Linux IP/networking
world, this is not generally reflected in the cellular
universe. You see quite a bit of GTP fragmentation due to the fact
that the transport network simply has to deal with the MTU that has
been established via the control plane between SGSN and MS/UE, without
the GGSN even being part of that negotiation.

Also, you may very well have one "gtp0" tunnel device at the GGSN,
but you are establishing individual GTP tunnels to dozesn to hundreds of
different SGSNs at operators all over the world.  You cannot reliably
set the "gtp0" interface MTU to "the path MTU of the overlay network",
as the overlay network is in fact different for each of the SGSNs you're
talking to - and each may have a different path MTU.

So unless I'm missing something, I would currently vote for staying with
the current code, which uses the path MTU to the specific destination IP
address (the SGSN).

Regards,
	Harald

-- 
- Harald Welte <laforge@gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

  reply	other threads:[~2017-09-19 12:13 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  0:38 [PATCH net-next 00/14] gtp: Additional feature support Tom Herbert
2017-09-19  0:38 ` [PATCH net-next 01/14] iptunnel: Add common functions to get a tunnel route Tom Herbert
2017-09-19  7:30   ` kbuild test robot
2017-09-19  0:38 ` [PATCH net-next 02/14] vxlan: Call common functions to get tunnel routes Tom Herbert
2017-09-19  0:38 ` [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache Tom Herbert
2017-09-19  4:17   ` David Miller
2017-09-19 12:09     ` Harald Welte
2017-09-19 17:44       ` David Miller
2017-09-20 15:37       ` Andreas Schultz
2017-09-24  1:33         ` Harald Welte
2017-09-19 16:05     ` Tom Herbert
2017-09-19  0:38 ` [PATCH net-next 04/14] gtp: udp recv clean up Tom Herbert
2017-09-19  7:44   ` kbuild test robot
2017-09-19 11:32   ` Harald Welte
2017-09-19  0:38 ` [PATCH net-next 05/14] gtp: Remove special mtu handling Tom Herbert
2017-09-19 11:42   ` Harald Welte [this message]
2017-09-19 18:12     ` Tom Herbert
2017-09-19  0:38 ` [PATCH net-next 06/14] gtp: Eliminate pktinfo and add port configuration Tom Herbert
2017-09-19  0:38 ` [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets Tom Herbert
2017-09-19  4:19   ` David Miller
2017-09-19 12:12     ` Harald Welte
2017-09-19 17:42       ` David Miller
2017-09-20  0:11         ` Tom Herbert
2017-09-19 11:53   ` Harald Welte
2017-09-19  0:38 ` [PATCH net-next 08/14] gtp: Support encpasulating over IPv6 Tom Herbert
2017-09-19  4:19   ` David Miller
2017-09-20 18:03     ` Tom Herbert
2017-09-20 19:45       ` David Miller
2017-09-20 20:40         ` Tom Herbert
2017-09-21  0:04           ` Harald Welte
2017-09-21  0:16             ` Tom Herbert
2017-09-19 11:59   ` Harald Welte
2017-09-19  0:38 ` [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone Tom Herbert
2017-09-20 15:27   ` Andreas Schultz
2017-09-20 15:57     ` Tom Herbert
2017-09-20 16:07       ` Andreas Schultz
2017-09-20 16:24         ` Tom Herbert
2017-09-21  0:13           ` Harald Welte
2017-09-21  0:55             ` Tom Herbert
2017-09-21 15:12               ` Harald Welte
2017-09-21 16:43                 ` Tom Herbert
2017-09-24  2:16                   ` Harald Welte
2017-09-24 15:55                     ` Tom Herbert
2017-09-24 16:25                       ` Harald Welte
2017-09-24 17:18                         ` Tom Herbert
2017-09-19  0:39 ` [PATCH net-next 10/14] gtp: Add support for devnet Tom Herbert
2017-09-19  0:39 ` [PATCH net-next 11/14] net: Add a facility to support application defined GSO Tom Herbert
2017-09-19  4:21   ` David Miller
2017-09-19  0:39 ` [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum Tom Herbert
2017-09-19  4:24   ` David Miller
2017-09-20 18:09     ` Tom Herbert
2017-09-21  1:55       ` Harald Welte
2017-09-21 22:41         ` Tom Herbert
2017-09-19  0:39 ` [PATCH net-next 13/14] gtp: Support for GRO Tom Herbert
2017-09-19 11:57   ` kbuild test robot
2017-09-19 12:03   ` Harald Welte
2017-09-19  0:39 ` [PATCH net-next 14/14] gtp: GSO support Tom Herbert
2017-09-19 12:43 ` [PATCH net-next 00/14] gtp: Additional feature support Harald Welte
2017-09-19 15:59   ` Tom Herbert
2017-09-19 23:19     ` Harald Welte
2017-09-19 23:47       ` Tom Herbert
2017-09-21 15:38         ` Harald Welte
2017-09-20 15:34       ` Andreas Schultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919114205.z2txj6rwo2row7u4@nataraja \
    --to=laforge@gnumonks.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=rohit@quantonium.net \
    --cc=tom@quantonium.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox