From: Harald Welte <laforge@gnumonks.org>
To: David Miller <davem@davemloft.net>
Cc: tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,
rohit@quantonium.net
Subject: Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets
Date: Tue, 19 Sep 2017 20:12:45 +0800 [thread overview]
Message-ID: <20170919121245.t555dqwndhewmdyw@nataraja> (raw)
In-Reply-To: <20170918.211908.2152170523885516973.davem@davemloft.net>
Hi Dave,
On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote:
> > +static inline u32 ipv6_hashfn(const struct in6_addr *a)
> > +{
> > + return __ipv6_addr_jhash(a, gtp_h_initval);
> > +}
>
> I know you are just following the pattern of the existing "ipv4_hashfn()" here
> but this kind of stuff is not very global namespace friendly. Even simply
> adding a "gtp_" prefix to these hash functions would be a lot better.
I would agree if this was an inline function defined in a header file or
a non-static function. But where is the global namespace concern in
case of static inline functions defined and used in the same .c file?
If it makes you happy, I'm all for adding the prefix - I just would like
to understand the rationale better, thanks :)
Regards,
Harald
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
next prev parent reply other threads:[~2017-09-19 12:13 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 0:38 [PATCH net-next 00/14] gtp: Additional feature support Tom Herbert
2017-09-19 0:38 ` [PATCH net-next 01/14] iptunnel: Add common functions to get a tunnel route Tom Herbert
2017-09-19 7:30 ` kbuild test robot
2017-09-19 0:38 ` [PATCH net-next 02/14] vxlan: Call common functions to get tunnel routes Tom Herbert
2017-09-19 0:38 ` [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache Tom Herbert
2017-09-19 4:17 ` David Miller
2017-09-19 12:09 ` Harald Welte
2017-09-19 17:44 ` David Miller
2017-09-20 15:37 ` Andreas Schultz
2017-09-24 1:33 ` Harald Welte
2017-09-19 16:05 ` Tom Herbert
2017-09-19 0:38 ` [PATCH net-next 04/14] gtp: udp recv clean up Tom Herbert
2017-09-19 7:44 ` kbuild test robot
2017-09-19 11:32 ` Harald Welte
2017-09-19 0:38 ` [PATCH net-next 05/14] gtp: Remove special mtu handling Tom Herbert
2017-09-19 11:42 ` Harald Welte
2017-09-19 18:12 ` Tom Herbert
2017-09-19 0:38 ` [PATCH net-next 06/14] gtp: Eliminate pktinfo and add port configuration Tom Herbert
2017-09-19 0:38 ` [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets Tom Herbert
2017-09-19 4:19 ` David Miller
2017-09-19 12:12 ` Harald Welte [this message]
2017-09-19 17:42 ` David Miller
2017-09-20 0:11 ` Tom Herbert
2017-09-19 11:53 ` Harald Welte
2017-09-19 0:38 ` [PATCH net-next 08/14] gtp: Support encpasulating over IPv6 Tom Herbert
2017-09-19 4:19 ` David Miller
2017-09-20 18:03 ` Tom Herbert
2017-09-20 19:45 ` David Miller
2017-09-20 20:40 ` Tom Herbert
2017-09-21 0:04 ` Harald Welte
2017-09-21 0:16 ` Tom Herbert
2017-09-19 11:59 ` Harald Welte
2017-09-19 0:38 ` [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone Tom Herbert
2017-09-20 15:27 ` Andreas Schultz
2017-09-20 15:57 ` Tom Herbert
2017-09-20 16:07 ` Andreas Schultz
2017-09-20 16:24 ` Tom Herbert
2017-09-21 0:13 ` Harald Welte
2017-09-21 0:55 ` Tom Herbert
2017-09-21 15:12 ` Harald Welte
2017-09-21 16:43 ` Tom Herbert
2017-09-24 2:16 ` Harald Welte
2017-09-24 15:55 ` Tom Herbert
2017-09-24 16:25 ` Harald Welte
2017-09-24 17:18 ` Tom Herbert
2017-09-19 0:39 ` [PATCH net-next 10/14] gtp: Add support for devnet Tom Herbert
2017-09-19 0:39 ` [PATCH net-next 11/14] net: Add a facility to support application defined GSO Tom Herbert
2017-09-19 4:21 ` David Miller
2017-09-19 0:39 ` [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum Tom Herbert
2017-09-19 4:24 ` David Miller
2017-09-20 18:09 ` Tom Herbert
2017-09-21 1:55 ` Harald Welte
2017-09-21 22:41 ` Tom Herbert
2017-09-19 0:39 ` [PATCH net-next 13/14] gtp: Support for GRO Tom Herbert
2017-09-19 11:57 ` kbuild test robot
2017-09-19 12:03 ` Harald Welte
2017-09-19 0:39 ` [PATCH net-next 14/14] gtp: GSO support Tom Herbert
2017-09-19 12:43 ` [PATCH net-next 00/14] gtp: Additional feature support Harald Welte
2017-09-19 15:59 ` Tom Herbert
2017-09-19 23:19 ` Harald Welte
2017-09-19 23:47 ` Tom Herbert
2017-09-21 15:38 ` Harald Welte
2017-09-20 15:34 ` Andreas Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919121245.t555dqwndhewmdyw@nataraja \
--to=laforge@gnumonks.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rohit@quantonium.net \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox