* [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
@ 2017-12-05 14:37 Dan Carpenter
2017-12-05 14:43 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dan Carpenter @ 2017-12-05 14:37 UTC (permalink / raw)
To: Michael Chan, Sathya Perla; +Cc: netdev, kernel-janitors
Smatch warns that:
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
error: uninitialized symbol 'rc'.
"rc" is either uninitialized or set to zero here so we can just remove
the check.
Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
index d5031f436f83..125b146da031 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -157,9 +157,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
}
}
- if (rc)
- return rc;
-
/* Tunnel encap/decap action must be accompanied by a redirect action */
if ((actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP ||
actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_DECAP) &&
@@ -169,7 +166,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
return -EINVAL;
}
- return rc;
+ return 0;
}
#define GET_KEY(flow_cmd, key_type) \
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
2017-12-05 14:37 [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Dan Carpenter
@ 2017-12-05 14:43 ` Dan Carpenter
2017-12-06 19:00 ` David Miller
2017-12-06 19:16 ` Michael Chan
2 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2017-12-05 14:43 UTC (permalink / raw)
To: Michael Chan, Sathya Perla; +Cc: netdev, kernel-janitors
I'm sorry, I left out that this applies to net-next.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
2017-12-05 14:37 [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Dan Carpenter
2017-12-05 14:43 ` Dan Carpenter
@ 2017-12-06 19:00 ` David Miller
2017-12-06 19:16 ` Michael Chan
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-12-06 19:00 UTC (permalink / raw)
To: dan.carpenter; +Cc: michael.chan, sathya.perla, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 5 Dec 2017 17:37:52 +0300
> Smatch warns that:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
> error: uninitialized symbol 'rc'.
>
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
>
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Michael, please review.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
2017-12-05 14:37 [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Dan Carpenter
2017-12-05 14:43 ` Dan Carpenter
2017-12-06 19:00 ` David Miller
@ 2017-12-06 19:16 ` Michael Chan
2017-12-06 19:25 ` David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Michael Chan @ 2017-12-06 19:16 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Sathya Perla, Netdev, kernel-janitors
On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch warns that:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
> error: uninitialized symbol 'rc'.
>
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
>
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks.
Acked-by: Michael Chan <michael.chan@broadcom.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
2017-12-06 19:16 ` Michael Chan
@ 2017-12-06 19:25 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-12-06 19:25 UTC (permalink / raw)
To: michael.chan; +Cc: dan.carpenter, sathya.perla, netdev, kernel-janitors
From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 6 Dec 2017 11:16:55 -0800
> On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> Smatch warns that:
>>
>> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>> error: uninitialized symbol 'rc'.
>>
>> "rc" is either uninitialized or set to zero here so we can just remove
>> the check.
>>
>> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks.
>
> Acked-by: Michael Chan <michael.chan@broadcom.com>
Applied to net-next, thanks everyone.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-06 19:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 14:37 [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Dan Carpenter
2017-12-05 14:43 ` Dan Carpenter
2017-12-06 19:00 ` David Miller
2017-12-06 19:16 ` Michael Chan
2017-12-06 19:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox