From: Julian Wiedmann <jwi@linux.ibm.com>
To: David Miller <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>
Cc: Julian Wiedmann <jwi@linux.ibm.com>, <netdev@vger.kernel.org>
Subject: [PATCH net-next v2] tcp: remove SG-related comment in tcp_sendmsg()
Date: Mon, 9 Jul 2018 09:45:14 +0200 [thread overview]
Message-ID: <20180709074514.77218-1-jwi@linux.ibm.com> (raw)
In-Reply-To: <5057f0d2-1d48-1665-8f9b-6123f7d3302c@gmail.com>
Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
doesn't care whether the interface supports SG.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
v2: remove the whole comment (Eric)
net/ipv4/tcp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index bf461fa77ed6..6ce14f8e3562 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1275,9 +1275,6 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
int linear;
new_segment:
- /* Allocate new segment. If the interface is SG,
- * allocate skb fitting to single page.
- */
if (!sk_stream_memory_free(sk))
goto wait_for_sndbuf;
--
2.16.4
next prev parent reply other threads:[~2018-07-09 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 7:19 [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg() Julian Wiedmann
2018-07-06 10:08 ` Eric Dumazet
2018-07-09 7:45 ` Julian Wiedmann [this message]
2018-07-09 22:57 ` [PATCH net-next v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709074514.77218-1-jwi@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox