Re: [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg()

[Eric Dumazet <eric.dumazet@gmail.com>]

On 07/06/2018 12:19 AM, Julian Wiedmann wrote:
> Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
> doesn't care whether the interface supports SG.
> 
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> ---
>  net/ipv4/tcp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index bf461fa77ed6..516e89b57603 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1275,9 +1275,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
>  			int linear;
>  
>  new_segment:
> -			/* Allocate new segment. If the interface is SG,
> -			 * allocate skb fitting to single page.
> -			 */
> +			/* Allocate new segment. */

Hi Julian

Please remove the comment completely then, it is really just redundant after this label.

Thanks.