* [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg()
@ 2018-07-06 7:19 Julian Wiedmann
2018-07-06 10:08 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: Julian Wiedmann @ 2018-07-06 7:19 UTC (permalink / raw)
To: David Miller, Eric Dumazet; +Cc: Julian Wiedmann, netdev
Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
doesn't care whether the interface supports SG.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
net/ipv4/tcp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index bf461fa77ed6..516e89b57603 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1275,9 +1275,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
int linear;
new_segment:
- /* Allocate new segment. If the interface is SG,
- * allocate skb fitting to single page.
- */
+ /* Allocate new segment. */
if (!sk_stream_memory_free(sk))
goto wait_for_sndbuf;
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg()
2018-07-06 7:19 [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg() Julian Wiedmann
@ 2018-07-06 10:08 ` Eric Dumazet
2018-07-09 7:45 ` [PATCH net-next v2] " Julian Wiedmann
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2018-07-06 10:08 UTC (permalink / raw)
To: Julian Wiedmann, David Miller, Eric Dumazet; +Cc: netdev
On 07/06/2018 12:19 AM, Julian Wiedmann wrote:
> Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
> doesn't care whether the interface supports SG.
>
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> ---
> net/ipv4/tcp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index bf461fa77ed6..516e89b57603 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1275,9 +1275,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
> int linear;
>
> new_segment:
> - /* Allocate new segment. If the interface is SG,
> - * allocate skb fitting to single page.
> - */
> + /* Allocate new segment. */
Hi Julian
Please remove the comment completely then, it is really just redundant after this label.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH net-next v2] tcp: remove SG-related comment in tcp_sendmsg()
2018-07-06 10:08 ` Eric Dumazet
@ 2018-07-09 7:45 ` Julian Wiedmann
2018-07-09 22:57 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Julian Wiedmann @ 2018-07-09 7:45 UTC (permalink / raw)
To: David Miller, Eric Dumazet; +Cc: Julian Wiedmann, netdev
Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
doesn't care whether the interface supports SG.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
v2: remove the whole comment (Eric)
net/ipv4/tcp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index bf461fa77ed6..6ce14f8e3562 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1275,9 +1275,6 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
int linear;
new_segment:
- /* Allocate new segment. If the interface is SG,
- * allocate skb fitting to single page.
- */
if (!sk_stream_memory_free(sk))
goto wait_for_sndbuf;
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] tcp: remove SG-related comment in tcp_sendmsg()
2018-07-09 7:45 ` [PATCH net-next v2] " Julian Wiedmann
@ 2018-07-09 22:57 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-07-09 22:57 UTC (permalink / raw)
To: jwi; +Cc: edumazet, netdev
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Mon, 9 Jul 2018 09:45:14 +0200
> Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
> doesn't care whether the interface supports SG.
>
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> ---
> v2: remove the whole comment (Eric)
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-09 22:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-06 7:19 [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg() Julian Wiedmann
2018-07-06 10:08 ` Eric Dumazet
2018-07-09 7:45 ` [PATCH net-next v2] " Julian Wiedmann
2018-07-09 22:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox