From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, lists@wiesinger.com, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: Keep CPU port as tagged in all VLANs
Date: Thu, 04 Oct 2018 21:53:06 -0700 (PDT) [thread overview]
Message-ID: <20181004.215306.257567278871187581.davem@davemloft.net> (raw)
In-Reply-To: <20181005032413.8866-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 4 Oct 2018 20:24:13 -0700
> Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port
> incorrectly") was a bit too trigger happy in removing the CPU port from
> the VLAN membership because we rely on DSA to program the CPU port VLAN,
> which it does, except it does not bother itself with tagged/untagged and
> just usese untagged.
>
> Having the CPU port "follow" the user ports tagged/untagged is not great
> and does not allow for properly differentiating, so keep the CPU port
> tagged in all VLANs.
>
> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
parent reply other threads:[~2018-10-05 4:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20181005032413.8866-1-f.fainelli@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004.215306.257567278871187581.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@wiesinger.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox