* Re: [PATCH net] net: dsa: b53: Keep CPU port as tagged in all VLANs
[not found] <20181005032413.8866-1-f.fainelli@gmail.com>
@ 2018-10-05 4:53 ` David Miller
0 siblings, 0 replies; only message in thread
From: David Miller @ 2018-10-05 4:53 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, lists, andrew, vivien.didelot, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 4 Oct 2018 20:24:13 -0700
> Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port
> incorrectly") was a bit too trigger happy in removing the CPU port from
> the VLAN membership because we rely on DSA to program the CPU port VLAN,
> which it does, except it does not bother itself with tagged/untagged and
> just usese untagged.
>
> Having the CPU port "follow" the user ports tagged/untagged is not great
> and does not allow for properly differentiating, so keep the CPU port
> tagged in all VLANs.
>
> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] only message in thread