From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Ahern <dsahern@gmail.com>
Cc: wenxu@ucloud.cn, fw@strlen.de, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type
Date: Fri, 18 Jan 2019 15:30:49 +0100 [thread overview]
Message-ID: <20190118143049.i2wakdxsr5oonnl6@salvia> (raw)
In-Reply-To: <a1a3c7cc-cdd5-3409-8296-f057c6e869c6@gmail.com>
On Fri, Jan 18, 2019 at 07:27:48AM -0700, David Ahern wrote:
> On 1/18/19 7:24 AM, Pablo Neira Ayuso wrote:
> >
> > There is no other way to identify a vft device rather than this
> > string? The only l3mdev that exists if vrf, right?
>
> ipvlan uses some of the hooks.
>
> >
> > If there is no other alternative, we can just place this in the tree,
> > but probably it would be better to have a numeric way to identify a
> > vrf device?
>
> IFF_L3MDEV_MASTER and IFF_L3MDEV_SLAVE are used via netif_is_l3_master
> and netif_is_l3_slave in all of the code. This was done because of
> requests to not bleed 'vrf' all over core kernel code.
Thanks for explaining.
So no other way than this string to identify vrf device, right?
next prev parent reply other threads:[~2019-01-18 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 23:53 [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type wenxu
2019-01-18 14:24 ` Pablo Neira Ayuso
2019-01-18 14:27 ` David Ahern
2019-01-18 14:30 ` Pablo Neira Ayuso [this message]
2019-01-18 14:32 ` Florian Westphal
2019-01-18 14:35 ` Pablo Neira Ayuso
2019-01-24 13:51 ` wenxu
2019-01-24 13:59 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118143049.i2wakdxsr5oonnl6@salvia \
--to=pablo@netfilter.org \
--cc=dsahern@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox