From: David Ahern <dsahern@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>, wenxu@ucloud.cn
Cc: fw@strlen.de, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type
Date: Fri, 18 Jan 2019 07:27:48 -0700 [thread overview]
Message-ID: <a1a3c7cc-cdd5-3409-8296-f057c6e869c6@gmail.com> (raw)
In-Reply-To: <20190118142430.rsnru4hyrbsodobf@salvia>
On 1/18/19 7:24 AM, Pablo Neira Ayuso wrote:
>
> There is no other way to identify a vft device rather than this
> string? The only l3mdev that exists if vrf, right?
ipvlan uses some of the hooks.
>
> If there is no other alternative, we can just place this in the tree,
> but probably it would be better to have a numeric way to identify a
> vrf device?
IFF_L3MDEV_MASTER and IFF_L3MDEV_SLAVE are used via netif_is_l3_master
and netif_is_l3_slave in all of the code. This was done because of
requests to not bleed 'vrf' all over core kernel code.
next prev parent reply other threads:[~2019-01-18 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 23:53 [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type wenxu
2019-01-18 14:24 ` Pablo Neira Ayuso
2019-01-18 14:27 ` David Ahern [this message]
2019-01-18 14:30 ` Pablo Neira Ayuso
2019-01-18 14:32 ` Florian Westphal
2019-01-18 14:35 ` Pablo Neira Ayuso
2019-01-24 13:51 ` wenxu
2019-01-24 13:59 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a3c7cc-cdd5-3409-8296-f057c6e869c6@gmail.com \
--to=dsahern@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox