From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
jiri@resnulli.us, andrew@lunn.ch, f.fainelli@gmail.com,
mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com
Subject: Re: [PATCH net-next v4 0/8] devlink: add device (driver) information API
Date: Fri, 01 Feb 2019 15:36:38 -0800 (PST) [thread overview]
Message-ID: <20190201.153638.647120007389173035.davem@davemloft.net> (raw)
In-Reply-To: <20190131185047.27685-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 31 Jan 2019 10:50:39 -0800
> fw_version field in ethtool -i does not suit modern needs with 31
> characters being quite limiting on more complex systems. There is
> also no distinction between the running and flashed versions of
> the firmware.
>
> Since the driver information pertains to the entire device, rather
> than a particular netdev, it seems wise to move it do devlink, at
> the same time fixing the aforementioned issues.
>
> The new API allows exposing the device serial number and versions
> of the components of the card - both hardware, firmware (running
> and flashed). Driver authors can choose descriptive identifiers
> for the version fields. A few version identifiers which seemed
> relevant for most devices have been added to the global devlink
> header.
>
> Example:
...
> Last patch also includes a compat code for ethtool. If driver
> reports no fw_version via the traditional ethtool API, ethtool
> can call into devlink and try to cram as many versions as possible
> into the 31 characters.
...
Series applied.
prev parent reply other threads:[~2019-02-01 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:50 [PATCH net-next v4 0/8] devlink: add device (driver) information API Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 1/8] devlink: add device " Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 2/8] devlink: add version reporting to devlink info API Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 3/8] devlink: add generic info version names Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 4/8] nfp: devlink: report driver name and serial number Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 5/8] nfp: devlink: report fixed versions Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 6/8] nfp: nsp: add support for versions command Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 7/8] nfp: devlink: report the running and flashed versions Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 8/8] ethtool: add compat for devlink info Jakub Kicinski
2019-02-01 7:58 ` Jiri Pirko
2019-02-01 23:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201.153638.647120007389173035.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=eugenem@fb.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=jonathan.lemon@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox