From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
oss-drivers@netronome.com, andrew@lunn.ch, f.fainelli@gmail.com,
mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com
Subject: Re: [PATCH net-next v4 8/8] ethtool: add compat for devlink info
Date: Fri, 1 Feb 2019 08:58:02 +0100 [thread overview]
Message-ID: <20190201075802.GB2401@nanopsycho> (raw)
In-Reply-To: <20190131185047.27685-9-jakub.kicinski@netronome.com>
Thu, Jan 31, 2019 at 07:50:47PM CET, jakub.kicinski@netronome.com wrote:
>If driver did not fill the fw_version field, try to call into
>the new devlink get_info op and collect the versions that way.
>We assume ethtool was always reporting running versions.
>
>v4:
> - use IS_REACHABLE() to avoid problems with DEVLINK=m (kbuildbot).
>v3 (Jiri):
> - do a dump and then parse it instead of special handling;
> - concatenate all versions (well, all that fit :)).
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2019-02-01 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:50 [PATCH net-next v4 0/8] devlink: add device (driver) information API Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 1/8] devlink: add device " Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 2/8] devlink: add version reporting to devlink info API Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 3/8] devlink: add generic info version names Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 4/8] nfp: devlink: report driver name and serial number Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 5/8] nfp: devlink: report fixed versions Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 6/8] nfp: nsp: add support for versions command Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 7/8] nfp: devlink: report the running and flashed versions Jakub Kicinski
2019-01-31 18:50 ` [PATCH net-next v4 8/8] ethtool: add compat for devlink info Jakub Kicinski
2019-02-01 7:58 ` Jiri Pirko [this message]
2019-02-01 23:36 ` [PATCH net-next v4 0/8] devlink: add device (driver) information API David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201075802.GB2401@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eugenem@fb.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jonathan.lemon@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox