* [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode.
@ 2019-02-13 14:40 Matteo Croce
2019-02-13 22:04 ` Stephen Hemminger
2019-02-13 22:07 ` Daniel Borkmann
0 siblings, 2 replies; 5+ messages in thread
From: Matteo Croce @ 2019-02-13 14:40 UTC (permalink / raw)
To: netdev; +Cc: David Ahern, Stephen Hemminger, Jakub Kicinski
When attaching an eBPF program to a device, ip link can force the XDP mode
by using the xdp{generic,drv,offload} keyword instead of just 'xdp'.
Document this behaviour also in the help output.
Signed-off-by: Matteo Croce <mcroce@redhat.com>
Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode")
Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload")
---
ip/iplink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index b5519201..3a0cf459 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -98,7 +98,7 @@ void iplink_usage(void)
" [ trust { on | off} ] ]\n"
" [ node_guid { eui64 } ]\n"
" [ port_guid { eui64 } ]\n"
- " [ xdp { off |\n"
+ " [ { xdp | xdpgeneric | xdpdrv | xdpoffload } { off |\n"
" object FILE [ section NAME ] [ verbose ] |\n"
" pinned FILE } ]\n"
" [ master DEVICE ][ vrf NAME ]\n"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode.
2019-02-13 14:40 [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode Matteo Croce
@ 2019-02-13 22:04 ` Stephen Hemminger
2019-02-14 14:01 ` Matteo Croce
2019-02-13 22:07 ` Daniel Borkmann
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2019-02-13 22:04 UTC (permalink / raw)
To: Matteo Croce; +Cc: netdev, David Ahern, Stephen Hemminger, Jakub Kicinski
On Wed, 13 Feb 2019 15:40:30 +0100
Matteo Croce <mcroce@redhat.com> wrote:
> When attaching an eBPF program to a device, ip link can force the XDP mode
> by using the xdp{generic,drv,offload} keyword instead of just 'xdp'.
> Document this behaviour also in the help output.
>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode")
> Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload")
Applied, thanks.
The man page already has this as well.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode.
2019-02-13 22:04 ` Stephen Hemminger
@ 2019-02-14 14:01 ` Matteo Croce
2019-02-14 16:29 ` Stephen Hemminger
0 siblings, 1 reply; 5+ messages in thread
From: Matteo Croce @ 2019-02-14 14:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, David Ahern, Stephen Hemminger, Jakub Kicinski
On Wed, Feb 13, 2019 at 11:04 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 13 Feb 2019 15:40:30 +0100
> Matteo Croce <mcroce@redhat.com> wrote:
>
> > When attaching an eBPF program to a device, ip link can force the XDP mode
> > by using the xdp{generic,drv,offload} keyword instead of just 'xdp'.
> > Document this behaviour also in the help output.
> >
> > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode")
> > Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload")
>
> Applied, thanks.
> The man page already has this as well.
>
Yes, I found it just after I made the patch. However, it could be nice
to have the generic "xdp" and a command like "type" or "mode" to
specify the XDP mode, eg.
ip link set dev eth0 xdp mode [ auto | generic | drv | offload ]
I was trying to add it, but unfortunately it seems that the arguments
aren't parsed in a loop, and are required to be in the exact order.
Would this change make sense?
Regards,
--
Matteo Croce
per aspera ad upstream
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode.
2019-02-14 14:01 ` Matteo Croce
@ 2019-02-14 16:29 ` Stephen Hemminger
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2019-02-14 16:29 UTC (permalink / raw)
To: Matteo Croce; +Cc: netdev, David Ahern, Stephen Hemminger, Jakub Kicinski
On Thu, 14 Feb 2019 15:01:26 +0100
Matteo Croce <mcroce@redhat.com> wrote:
> On Wed, Feb 13, 2019 at 11:04 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Wed, 13 Feb 2019 15:40:30 +0100
> > Matteo Croce <mcroce@redhat.com> wrote:
> >
> > > When attaching an eBPF program to a device, ip link can force the XDP mode
> > > by using the xdp{generic,drv,offload} keyword instead of just 'xdp'.
> > > Document this behaviour also in the help output.
> > >
> > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > > Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode")
> > > Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload")
> >
> > Applied, thanks.
> > The man page already has this as well.
> >
>
> Yes, I found it just after I made the patch. However, it could be nice
> to have the generic "xdp" and a command like "type" or "mode" to
> specify the XDP mode, eg.
> ip link set dev eth0 xdp mode [ auto | generic | drv | offload ]
> I was trying to add it, but unfortunately it seems that the arguments
> aren't parsed in a loop, and are required to be in the exact order.
> Would this change make sense?
>
> Regards,
>
> --
> Matteo Croce
> per aspera ad upstream
It would have made sense to start with, but the syntax is more or less fixed
by now.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode.
2019-02-13 14:40 [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode Matteo Croce
2019-02-13 22:04 ` Stephen Hemminger
@ 2019-02-13 22:07 ` Daniel Borkmann
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Borkmann @ 2019-02-13 22:07 UTC (permalink / raw)
To: Matteo Croce, netdev; +Cc: David Ahern, Stephen Hemminger, Jakub Kicinski
On 02/13/2019 03:40 PM, Matteo Croce wrote:
> When attaching an eBPF program to a device, ip link can force the XDP mode
> by using the xdp{generic,drv,offload} keyword instead of just 'xdp'.
> Document this behaviour also in the help output.
>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode")
> Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-14 16:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 14:40 [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode Matteo Croce
2019-02-13 22:04 ` Stephen Hemminger
2019-02-14 14:01 ` Matteo Croce
2019-02-14 16:29 ` Stephen Hemminger
2019-02-13 22:07 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox