From: David Miller <davem@davemloft.net>
To: laoar.shao@gmail.com
Cc: daniel@iogearbox.net, edumazet@google.com, joe@perches.com,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
shaoyafang@didiglobal.com
Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING
Date: Sat, 23 Feb 2019 13:21:17 -0800 (PST) [thread overview]
Message-ID: <20190223.132117.343025457687449183.davem@davemloft.net> (raw)
In-Reply-To: <1550413592-7877-3-git-send-email-laoar.shao@gmail.com>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Sun, 17 Feb 2019 22:26:32 +0800
> SOCK_DEBUG() is a old facility for debugging.
> If the user want to use it for debugging, the user must modify the
> application first, that doesn't seem like a good way.
> Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind
> of debugging purpose.
> So we'd better disable it by default.
> The reason why I don't remove it comepletely is that someone may still
> would like to use it for debugging.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> Suggested-by: Joe Perches <joe@perches.com>
Sorry, I'm not applying this.
You are forcing everyone who wants to use this to add a curstom local
source code change into their build.
I'm OK with patch #1, and Eric suggested it, so if you want to submit
that separately that's fine.
next prev parent reply other threads:[~2019-02-23 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 14:26 [PATCH v3 net-next 0/2] clean up SOCK_DEBUG() Yafang Shao
2019-02-17 14:26 ` [PATCH v3 net-next 1/2] tcp: " Yafang Shao
2019-02-17 14:26 ` [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING Yafang Shao
2019-02-23 21:21 ` David Miller [this message]
2019-02-23 22:13 ` Joe Perches
2019-02-24 1:11 ` Cong Wang
2019-02-24 2:30 ` David Miller
2019-02-25 22:00 ` Cong Wang
2019-02-25 22:29 ` David Miller
2019-02-25 22:58 ` Cong Wang
2019-02-25 23:11 ` David Miller
2019-02-25 23:11 ` David Miller
2019-02-25 23:18 ` Cong Wang
2019-02-25 23:54 ` Yafang Shao
2019-02-24 1:26 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223.132117.343025457687449183.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shaoyafang@didiglobal.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox