From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: laoar.shao@gmail.com, daniel@iogearbox.net, edumazet@google.com,
joe@perches.com, netdev@vger.kernel.org,
shaoyafang@didiglobal.com
Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING
Date: Mon, 25 Feb 2019 14:29:39 -0800 (PST) [thread overview]
Message-ID: <20190225.142939.803768996918170563.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpUePM2L5qStoq7XmQe-4sDrM9n6BRwa=FShfzZda=Lccw@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 25 Feb 2019 14:00:09 -0800
> Just to clarify, I have been suggesting to completely remove
> this unused macro, never suggest to just undefine it in-tree.
>
> There is no reason to keep it in-tree, whether defined or undefined,
> just for downstream users.
And this is where you and I fundamentally disagree.
next prev parent reply other threads:[~2019-02-25 22:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 14:26 [PATCH v3 net-next 0/2] clean up SOCK_DEBUG() Yafang Shao
2019-02-17 14:26 ` [PATCH v3 net-next 1/2] tcp: " Yafang Shao
2019-02-17 14:26 ` [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING Yafang Shao
2019-02-23 21:21 ` David Miller
2019-02-23 22:13 ` Joe Perches
2019-02-24 1:11 ` Cong Wang
2019-02-24 2:30 ` David Miller
2019-02-25 22:00 ` Cong Wang
2019-02-25 22:29 ` David Miller [this message]
2019-02-25 22:58 ` Cong Wang
2019-02-25 23:11 ` David Miller
2019-02-25 23:11 ` David Miller
2019-02-25 23:18 ` Cong Wang
2019-02-25 23:54 ` Yafang Shao
2019-02-24 1:26 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225.142939.803768996918170563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shaoyafang@didiglobal.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox