From: Ido Schimmel <idosch@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>
Subject: [PATCH net-next 10/15] mlxsw: spectrum_acl: Remove RTNL lock assertions from ERP code
Date: Sun, 24 Feb 2019 06:46:30 +0000 [thread overview]
Message-ID: <20190224064525.14913-11-idosch@mellanox.com> (raw)
In-Reply-To: <20190224064525.14913-1-idosch@mellanox.com>
From: Jiri Pirko <jiri@mellanox.com>
No longer require RTNL lock in this code. Newly introduced mutexes take
care of guarding objagg and bloom filter. There is no need to guard
gen_pool_alloc()/gen_pool_free() as they are fine to be called lockless.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c
index d6961dd0c556..c1a9cc9a3292 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c
@@ -1007,11 +1007,6 @@ mlxsw_sp_acl_erp_mask_get(struct mlxsw_sp_acl_atcam_region *aregion,
struct mlxsw_sp_acl_erp_key key;
struct objagg_obj *objagg_obj;
- /* eRPs are allocated from a shared resource, but currently all
- * allocations are done under RTNL.
- */
- ASSERT_RTNL();
-
memcpy(key.mask, mask, MLXSW_REG_PTCEX_FLEX_KEY_BLOCKS_LEN);
key.ctcam = ctcam;
mutex_lock(&erp_table->objagg_lock);
@@ -1042,7 +1037,6 @@ int mlxsw_sp_acl_erp_bf_insert(struct mlxsw_sp *mlxsw_sp,
const struct mlxsw_sp_acl_erp *erp = objagg_obj_root_priv(objagg_obj);
unsigned int erp_bank;
- ASSERT_RTNL();
if (!mlxsw_sp_acl_erp_table_is_used(erp->erp_table))
return 0;
--
2.20.1
next prev parent reply other threads:[~2019-02-24 6:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 6:46 [PATCH net-next 00/15] mlxsw: spectrum_acl: Don't take rtnl mutex for region rehash Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 01/15] mlxsw: spectrum_acl: Remove unused ops field from group structure Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 02/15] mlxsw: spectrum_acl: Split TCAM group structure into two Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 03/15] mlxsw: spectrum_acl: Introduce a mutex to guard region list updates Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 04/15] mlxsw: spectrum_acl: Refactor vregion association code Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 05/15] mlxsw: spectrum_acl: Introduce vregion mutex Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 06/15] mlxsw: spectrum_acl: Introduce mutex to guard Bloom Filter updates Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 08/15] mlxsw: spectrum_acl: Enable vregion rehash per-profile Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 07/15] mlxsw: spectrum_acl: Introduce a mutex to guard objagg instance manipulation Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 09/15] mlxsw: spectrum_acl: Don't take rtnl lock during vregion_rehash_intrvl_set() Ido Schimmel
2019-02-24 6:46 ` Ido Schimmel [this message]
2019-02-24 6:46 ` [PATCH net-next 11/15] mlxsw: spectrum_acl: Don't take mutex in mlxsw_sp_acl_tcam_vregion_rehash_work() Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 12/15] selftests: mlxsw: spectrum-2: Add IPv6 variant of simple delta rehash test Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 14/15] selftests: mlxsw: spectrum-2: Check migrate end trace Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 13/15] mlxsw: spectrum_acl: Add vregion migration end tracepoint Ido Schimmel
2019-02-24 6:46 ` [PATCH net-next 15/15] selftests: mlxsw: spectrum-2: Add massive delta rehash test Ido Schimmel
2019-02-25 4:26 ` [PATCH net-next 00/15] mlxsw: spectrum_acl: Don't take rtnl mutex for region rehash David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190224064525.14913-11-idosch@mellanox.com \
--to=idosch@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox