Netdev List
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	Jiri Pirko <jiri@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>
Subject: [PATCH net-next 11/15] mlxsw: spectrum_acl: Don't take mutex in mlxsw_sp_acl_tcam_vregion_rehash_work()
Date: Sun, 24 Feb 2019 06:46:31 +0000	[thread overview]
Message-ID: <20190224064525.14913-12-idosch@mellanox.com> (raw)
In-Reply-To: <20190224064525.14913-1-idosch@mellanox.com>

From: Jiri Pirko <jiri@mellanox.com>

Other mutexes are taking care of proper locking for this, no longer
needed to take RTNL mutex here.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
index 5c8976e471ad..822766f81236 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
@@ -732,12 +732,7 @@ static void mlxsw_sp_acl_tcam_vregion_rehash_work(struct work_struct *work)
 		container_of(work, struct mlxsw_sp_acl_tcam_vregion,
 			     rehash_dw.work);
 
-	/* TODO: Take rtnl lock here as the rest of the code counts on it
-	 * now. Later, this should be replaced by per-vregion lock.
-	 */
-	rtnl_lock();
 	mlxsw_sp_acl_tcam_vregion_rehash(vregion->mlxsw_sp, vregion);
-	rtnl_unlock();
 	mlxsw_sp_acl_tcam_vregion_rehash_work_schedule(vregion);
 }
 
-- 
2.20.1


  parent reply	other threads:[~2019-02-24  6:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-24  6:46 [PATCH net-next 00/15] mlxsw: spectrum_acl: Don't take rtnl mutex for region rehash Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 01/15] mlxsw: spectrum_acl: Remove unused ops field from group structure Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 02/15] mlxsw: spectrum_acl: Split TCAM group structure into two Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 03/15] mlxsw: spectrum_acl: Introduce a mutex to guard region list updates Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 04/15] mlxsw: spectrum_acl: Refactor vregion association code Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 05/15] mlxsw: spectrum_acl: Introduce vregion mutex Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 06/15] mlxsw: spectrum_acl: Introduce mutex to guard Bloom Filter updates Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 07/15] mlxsw: spectrum_acl: Introduce a mutex to guard objagg instance manipulation Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 08/15] mlxsw: spectrum_acl: Enable vregion rehash per-profile Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 09/15] mlxsw: spectrum_acl: Don't take rtnl lock during vregion_rehash_intrvl_set() Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 10/15] mlxsw: spectrum_acl: Remove RTNL lock assertions from ERP code Ido Schimmel
2019-02-24  6:46 ` Ido Schimmel [this message]
2019-02-24  6:46 ` [PATCH net-next 12/15] selftests: mlxsw: spectrum-2: Add IPv6 variant of simple delta rehash test Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 13/15] mlxsw: spectrum_acl: Add vregion migration end tracepoint Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 14/15] selftests: mlxsw: spectrum-2: Check migrate end trace Ido Schimmel
2019-02-24  6:46 ` [PATCH net-next 15/15] selftests: mlxsw: spectrum-2: Add massive delta rehash test Ido Schimmel
2019-02-25  4:26 ` [PATCH net-next 00/15] mlxsw: spectrum_acl: Don't take rtnl mutex for region rehash David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190224064525.14913-12-idosch@mellanox.com \
    --to=idosch@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox