From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Roi Dayan <roid@mellanox.com>
Cc: "xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
Saeed Mahameed <saeedm@mellanox.com>,
"gerlitz.or@gmail.com" <gerlitz.or@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action
Date: Wed, 27 Feb 2019 21:02:59 +0100 [thread overview]
Message-ID: <20190227200259.ptwc7tkjejpenfnt@salvia> (raw)
In-Reply-To: <42e71e1f-0a51-c517-5a93-b8d9b8c0fecf@mellanox.com>
On Wed, Feb 27, 2019 at 02:05:02PM +0000, Roi Dayan wrote:
>
>
> On 26/02/2019 14:28, xiangxia.m.yue@gmail.com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > The capacity of FDB offloading and NIC offloading table are
> > different, and when allocating the pedit actions, we should
> > use the correct namespace type.
> >
> > Fixes: c500c86b0c75d ("net/mlx5e: support for two independent packet edit actions")
> > Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > index 3a02b22..467ef9e 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
> >
> > if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
> > hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> > - err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_KERNEL,
> > + err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_FDB,
> > parse_attr, hdrs, extack);
> > if (err)
> > return err;
> >
>
> Reviewed-by: Roi Dayan <roid@mellanox.com>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2019-02-27 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 12:28 [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action xiangxia.m.yue
2019-02-27 14:05 ` Roi Dayan
2019-02-27 20:02 ` Pablo Neira Ayuso [this message]
2019-03-01 19:43 ` Saeed Mahameed
2019-03-14 1:37 ` Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227200259.ptwc7tkjejpenfnt@salvia \
--to=pablo@netfilter.org \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roid@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox