* [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action
@ 2019-02-26 12:28 xiangxia.m.yue
2019-02-27 14:05 ` Roi Dayan
0 siblings, 1 reply; 5+ messages in thread
From: xiangxia.m.yue @ 2019-02-26 12:28 UTC (permalink / raw)
To: saeedm, gerlitz.or, roid; +Cc: netdev, Tonghao Zhang, Pablo Neira Ayuso
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
The capacity of FDB offloading and NIC offloading table are
different, and when allocating the pedit actions, we should
use the correct namespace type.
Fixes: c500c86b0c75d ("net/mlx5e: support for two independent packet edit actions")
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 3a02b22..467ef9e 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
- err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_KERNEL,
+ err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_FDB,
parse_attr, hdrs, extack);
if (err)
return err;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action
2019-02-26 12:28 [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action xiangxia.m.yue
@ 2019-02-27 14:05 ` Roi Dayan
2019-02-27 20:02 ` Pablo Neira Ayuso
0 siblings, 1 reply; 5+ messages in thread
From: Roi Dayan @ 2019-02-27 14:05 UTC (permalink / raw)
To: xiangxia.m.yue@gmail.com, Saeed Mahameed, gerlitz.or@gmail.com
Cc: netdev@vger.kernel.org, Pablo Neira Ayuso
On 26/02/2019 14:28, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> The capacity of FDB offloading and NIC offloading table are
> different, and when allocating the pedit actions, we should
> use the correct namespace type.
>
> Fixes: c500c86b0c75d ("net/mlx5e: support for two independent packet edit actions")
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index 3a02b22..467ef9e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
>
> if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
> hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> - err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_KERNEL,
> + err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_FDB,
> parse_attr, hdrs, extack);
> if (err)
> return err;
>
Reviewed-by: Roi Dayan <roid@mellanox.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action
2019-02-27 14:05 ` Roi Dayan
@ 2019-02-27 20:02 ` Pablo Neira Ayuso
2019-03-01 19:43 ` Saeed Mahameed
0 siblings, 1 reply; 5+ messages in thread
From: Pablo Neira Ayuso @ 2019-02-27 20:02 UTC (permalink / raw)
To: Roi Dayan
Cc: xiangxia.m.yue@gmail.com, Saeed Mahameed, gerlitz.or@gmail.com,
netdev@vger.kernel.org
On Wed, Feb 27, 2019 at 02:05:02PM +0000, Roi Dayan wrote:
>
>
> On 26/02/2019 14:28, xiangxia.m.yue@gmail.com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > The capacity of FDB offloading and NIC offloading table are
> > different, and when allocating the pedit actions, we should
> > use the correct namespace type.
> >
> > Fixes: c500c86b0c75d ("net/mlx5e: support for two independent packet edit actions")
> > Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > index 3a02b22..467ef9e 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
> >
> > if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
> > hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> > - err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_KERNEL,
> > + err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_FDB,
> > parse_attr, hdrs, extack);
> > if (err)
> > return err;
> >
>
> Reviewed-by: Roi Dayan <roid@mellanox.com>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action
2019-02-27 20:02 ` Pablo Neira Ayuso
@ 2019-03-01 19:43 ` Saeed Mahameed
2019-03-14 1:37 ` Tonghao Zhang
0 siblings, 1 reply; 5+ messages in thread
From: Saeed Mahameed @ 2019-03-01 19:43 UTC (permalink / raw)
To: pablo@netfilter.org, Roi Dayan
Cc: netdev@vger.kernel.org, xiangxia.m.yue@gmail.com,
gerlitz.or@gmail.com
On Wed, 2019-02-27 at 21:02 +0100, Pablo Neira Ayuso wrote:
> On Wed, Feb 27, 2019 at 02:05:02PM +0000, Roi Dayan wrote:
> >
> > On 26/02/2019 14:28, xiangxia.m.yue@gmail.com wrote:
> > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > >
> > > The capacity of FDB offloading and NIC offloading table are
> > > different, and when allocating the pedit actions, we should
> > > use the correct namespace type.
> > >
> > > Fixes: c500c86b0c75d ("net/mlx5e: support for two independent
> > > packet edit actions")
> > > Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > > ---
> > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > index 3a02b22..467ef9e 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct
> > > mlx5e_priv *priv,
> > >
> > > if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
> > > hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> > > - err = alloc_tc_pedit_action(priv,
> > > MLX5_FLOW_NAMESPACE_KERNEL,
> > > + err = alloc_tc_pedit_action(priv,
> > > MLX5_FLOW_NAMESPACE_FDB,
> > > parse_attr, hdrs, extack);
> > > if (err)
> > > return err;
> > >
> >
> > Reviewed-by: Roi Dayan <roid@mellanox.com>
>
> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Dave, can you please apply this directly to net-next ?
Thanks,
Saeed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action
2019-03-01 19:43 ` Saeed Mahameed
@ 2019-03-14 1:37 ` Tonghao Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Tonghao Zhang @ 2019-03-14 1:37 UTC (permalink / raw)
To: David Miller
Cc: pablo@netfilter.org, Roi Dayan, netdev@vger.kernel.org,
gerlitz.or@gmail.com, Saeed Mahameed
On Sat, Mar 2, 2019 at 3:43 AM Saeed Mahameed <saeedm@mellanox.com> wrote:
>
> On Wed, 2019-02-27 at 21:02 +0100, Pablo Neira Ayuso wrote:
> > On Wed, Feb 27, 2019 at 02:05:02PM +0000, Roi Dayan wrote:
> > >
> > > On 26/02/2019 14:28, xiangxia.m.yue@gmail.com wrote:
> > > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > > >
> > > > The capacity of FDB offloading and NIC offloading table are
> > > > different, and when allocating the pedit actions, we should
> > > > use the correct namespace type.
> > > >
> > > > Fixes: c500c86b0c75d ("net/mlx5e: support for two independent
> > > > packet edit actions")
> > > > Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> > > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > > > ---
> > > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > > index 3a02b22..467ef9e 100644
> > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > > @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct
> > > > mlx5e_priv *priv,
> > > >
> > > > if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
> > > > hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> > > > - err = alloc_tc_pedit_action(priv,
> > > > MLX5_FLOW_NAMESPACE_KERNEL,
> > > > + err = alloc_tc_pedit_action(priv,
> > > > MLX5_FLOW_NAMESPACE_FDB,
> > > > parse_attr, hdrs, extack);
> > > > if (err)
> > > > return err;
> > > >
> > >
> > > Reviewed-by: Roi Dayan <roid@mellanox.com>
> >
> > Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Acked-by: Saeed Mahameed <saeedm@mellanox.com>
>
> Dave, can you please apply this directly to net-next ?
will be applied to net-next, or net ? this patch is a bugfix.
> Thanks,
> Saeed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-14 1:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-26 12:28 [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action xiangxia.m.yue
2019-02-27 14:05 ` Roi Dayan
2019-02-27 20:02 ` Pablo Neira Ayuso
2019-03-01 19:43 ` Saeed Mahameed
2019-03-14 1:37 ` Tonghao Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox