Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Wang Chen <wangchen@cn.fujitsu.com>,
	David Miller <davem@davemloft.net>,
	Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow
Date: Mon, 8 Apr 2019 20:52:21 +0800	[thread overview]
Message-ID: <20190408125221.GR10051@dhcp-12-139.nay.redhat.com> (raw)
In-Reply-To: <20190407084324.48a081f0@shemminger-XPS-13-9360>

On Sun, Apr 07, 2019 at 08:43:24AM -0700, Stephen Hemminger wrote:
> On Thu,  4 Apr 2019 20:45:18 +0800
> Hangbin Liu <liuhangbin@gmail.com> wrote:
> 
> > Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti
> > overflow"), we should not decrease promiscuity if it is already 0.
> 
> This should never happen. If it is a kernel bug and should be reported
> like refcnt_t overflow.

Hi Stephen,

The type of promiscuity and allmulti is 'unsigned int'. That why it happened.

Thanks
Hangbin

      reply	other threads:[~2019-04-08 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 12:45 [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow Hangbin Liu
2019-04-07  1:14 ` David Miller
2019-04-08 12:50   ` Hangbin Liu
2019-04-07 15:43 ` Stephen Hemminger
2019-04-08 12:52   ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408125221.GR10051@dhcp-12-139.nay.redhat.com \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=wangchen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox