From: David Miller <davem@davemloft.net>
To: ast@domdv.de
Cc: netdev@vger.kernel.org
Subject: Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs
Date: Thu, 23 May 2019 09:11:06 -0700 (PDT) [thread overview]
Message-ID: <20190523.091106.645519899189717299.davem@davemloft.net> (raw)
In-Reply-To: <32eb738a0a0f3ed5880911e4ac4ceedca76e3f52.camel@domdv.de>
From: Andreas Steinmetz <ast@domdv.de>
Date: Thu, 23 May 2019 09:46:15 +0200
> MACsec causes oopses followed by a kernel panic when attached directly or indirectly to a bridge. It causes erroneous
> checksum messages when attached to vxlan. When I did investigate I did find skb leaks, apparent skb mis-handling and
> superfluous code. The attached patch fixes all MACsec misbehaviour I could find. As I am no kernel developer somebody
> with sufficient kernel network knowledge should verify and correct the patch where necessary.
>
> Signed-off-by: Andreas Steinmetz <ast@domdv.de>
Subject lines should be of the form:
[PATCH $DST_TREE] $subsystem_prefix: Description.
Where $DST_TREE here would be "net" and $subsystem_prefix would be "macsec".
> + /* FIXME: any better way to prevent calls to netdev_rx_csum_fault? */
> + skb->csum_complete_sw = 1;
Create a helper for this in linux/skbuff.h with very clear and clean comments
explaining what is going on.
next prev parent reply other threads:[~2019-05-23 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 7:46 [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs Andreas Steinmetz
2019-05-23 16:11 ` David Miller [this message]
2019-05-27 17:50 ` Andreas Steinmetz
2019-05-24 10:09 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523.091106.645519899189717299.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@domdv.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox