From: Sabrina Dubroca <sd@queasysnail.net>
To: Andreas Steinmetz <ast@domdv.de>
Cc: netdev@vger.kernel.org
Subject: Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs
Date: Fri, 24 May 2019 12:09:14 +0200 [thread overview]
Message-ID: <20190524100914.GA20686@bistromath.localdomain> (raw)
In-Reply-To: <32eb738a0a0f3ed5880911e4ac4ceedca76e3f52.camel@domdv.de>
Hi Andreas,
2019-05-23, 09:46:15 +0200, Andreas Steinmetz wrote:
> MACsec causes oopses followed by a kernel panic when attached
> directly or indirectly to a bridge. It causes erroneous checksum
> messages when attached to vxlan.
It looks like you're fixing multiple separate bugs in a single patch,
which makes it really difficult to understand. You're also not
describing what the issues are, and why the changes you're proposing
are fixing those bugs.
Do you have reproducers for those bugs? That would be helpful, as I've
never seen the panics/leaks/checksum issues you're mentioning.
> When I did investigate I did find skb leaks, apparent skb mis-handling and
> superfluous code. The attached patch fixes all MACsec misbehaviour I could find.
Please fix only one issue per patch. Otherwise, it's really hard to
tell what change fixes which issue.
Thanks,
--
Sabrina
prev parent reply other threads:[~2019-05-24 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 7:46 [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs Andreas Steinmetz
2019-05-23 16:11 ` David Miller
2019-05-27 17:50 ` Andreas Steinmetz
2019-05-24 10:09 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524100914.GA20686@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=ast@domdv.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox