* [patch net-next v2] mlx5: Add missing init_net check in FIB notifier
@ 2019-08-30 8:25 Jiri Pirko
2019-09-01 7:38 ` Roi Dayan
2019-09-02 18:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2019-08-30 8:25 UTC (permalink / raw)
To: netdev; +Cc: davem, saeedm, leon, roid, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
Take only FIB events that are happening in init_net into account. No other
namespaces are supported.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
v1->v2:
- no change, just cced maintainers (fat finger made me avoid them in v1)
---
drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
index e69766393990..5d20d615663e 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
@@ -248,6 +248,9 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
struct net_device *fib_dev;
struct fib_info *fi;
+ if (!net_eq(info->net, &init_net))
+ return NOTIFY_DONE;
+
if (info->family != AF_INET)
return NOTIFY_DONE;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch net-next v2] mlx5: Add missing init_net check in FIB notifier
2019-08-30 8:25 [patch net-next v2] mlx5: Add missing init_net check in FIB notifier Jiri Pirko
@ 2019-09-01 7:38 ` Roi Dayan
2019-09-02 18:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Roi Dayan @ 2019-09-01 7:38 UTC (permalink / raw)
To: Jiri Pirko, netdev@vger.kernel.org
Cc: davem@davemloft.net, Saeed Mahameed, leon@kernel.org, mlxsw
On 2019-08-30 11:25 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Take only FIB events that are happening in init_net into account. No other
> namespaces are supported.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> v1->v2:
> - no change, just cced maintainers (fat finger made me avoid them in v1)
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
> index e69766393990..5d20d615663e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
> @@ -248,6 +248,9 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
> struct net_device *fib_dev;
> struct fib_info *fi;
>
> + if (!net_eq(info->net, &init_net))
> + return NOTIFY_DONE;
> +
> if (info->family != AF_INET)
> return NOTIFY_DONE;
>
>
thanks
Acked-by: Roi Dayan <roid@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch net-next v2] mlx5: Add missing init_net check in FIB notifier
2019-08-30 8:25 [patch net-next v2] mlx5: Add missing init_net check in FIB notifier Jiri Pirko
2019-09-01 7:38 ` Roi Dayan
@ 2019-09-02 18:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-09-02 18:45 UTC (permalink / raw)
To: jiri; +Cc: netdev, saeedm, leon, roid, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 30 Aug 2019 10:25:30 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Take only FIB events that are happening in init_net into account. No other
> namespaces are supported.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> v1->v2:
> - no change, just cced maintainers (fat finger made me avoid them in v1)
Applied, thanks Jiri.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-02 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-30 8:25 [patch net-next v2] mlx5: Add missing init_net check in FIB notifier Jiri Pirko
2019-09-01 7:38 ` Roi Dayan
2019-09-02 18:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox