* [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present
@ 2019-09-16 14:50 Murilo Fossa Vicentini
2019-09-16 15:21 ` Thomas Falcon
2019-09-20 0:37 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Murilo Fossa Vicentini @ 2019-09-16 14:50 UTC (permalink / raw)
To: netdev; +Cc: tlfalcon, muvic, abdhalee
With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link
state change") we are now able to detect when the carrier is properly
present in the device, so only report an unexpected unknown speed when it
is properly detected. Unknown speed is expected to be seen by the device
in case the backing device has no link detected.
Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Signed-off-by: Murilo Fossa Vicentini <muvic@linux.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 5cb55ea671e3..3a6725daf7dc 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -4312,13 +4312,14 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
{
struct net_device *netdev = adapter->netdev;
int rc;
+ __be32 rspeed = cpu_to_be32(crq->query_phys_parms_rsp.speed);
rc = crq->query_phys_parms_rsp.rc.code;
if (rc) {
netdev_err(netdev, "Error %d in QUERY_PHYS_PARMS\n", rc);
return rc;
}
- switch (cpu_to_be32(crq->query_phys_parms_rsp.speed)) {
+ switch (rspeed) {
case IBMVNIC_10MBPS:
adapter->speed = SPEED_10;
break;
@@ -4344,8 +4345,8 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
adapter->speed = SPEED_100000;
break;
default:
- netdev_warn(netdev, "Unknown speed 0x%08x\n",
- cpu_to_be32(crq->query_phys_parms_rsp.speed));
+ if (netif_carrier_ok(netdev))
+ netdev_warn(netdev, "Unknown speed 0x%08x\n", rspeed);
adapter->speed = SPEED_UNKNOWN;
}
if (crq->query_phys_parms_rsp.flags1 & IBMVNIC_FULL_DUPLEX)
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present
2019-09-16 14:50 [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present Murilo Fossa Vicentini
@ 2019-09-16 15:21 ` Thomas Falcon
2019-09-20 0:37 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Falcon @ 2019-09-16 15:21 UTC (permalink / raw)
To: Murilo Fossa Vicentini, netdev; +Cc: muvic, abdhalee
On 9/16/19 9:50 AM, Murilo Fossa Vicentini wrote:
> With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link
> state change") we are now able to detect when the carrier is properly
> present in the device, so only report an unexpected unknown speed when it
> is properly detected. Unknown speed is expected to be seen by the device
> in case the backing device has no link detected.
>
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Murilo Fossa Vicentini <muvic@linux.ibm.com>
> ---
Thanks, Murilo!
Reviewed-by: Thomas Falcon <tlfalcon@linux.ibm.com>
> drivers/net/ethernet/ibm/ibmvnic.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 5cb55ea671e3..3a6725daf7dc 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -4312,13 +4312,14 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
> {
> struct net_device *netdev = adapter->netdev;
> int rc;
> + __be32 rspeed = cpu_to_be32(crq->query_phys_parms_rsp.speed);
>
> rc = crq->query_phys_parms_rsp.rc.code;
> if (rc) {
> netdev_err(netdev, "Error %d in QUERY_PHYS_PARMS\n", rc);
> return rc;
> }
> - switch (cpu_to_be32(crq->query_phys_parms_rsp.speed)) {
> + switch (rspeed) {
> case IBMVNIC_10MBPS:
> adapter->speed = SPEED_10;
> break;
> @@ -4344,8 +4345,8 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
> adapter->speed = SPEED_100000;
> break;
> default:
> - netdev_warn(netdev, "Unknown speed 0x%08x\n",
> - cpu_to_be32(crq->query_phys_parms_rsp.speed));
> + if (netif_carrier_ok(netdev))
> + netdev_warn(netdev, "Unknown speed 0x%08x\n", rspeed);
> adapter->speed = SPEED_UNKNOWN;
> }
> if (crq->query_phys_parms_rsp.flags1 & IBMVNIC_FULL_DUPLEX)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present
2019-09-16 14:50 [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present Murilo Fossa Vicentini
2019-09-16 15:21 ` Thomas Falcon
@ 2019-09-20 0:37 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-09-20 0:37 UTC (permalink / raw)
To: Murilo Fossa Vicentini; +Cc: netdev, tlfalcon, muvic, abdhalee
On Mon, 16 Sep 2019 11:50:37 -0300, Murilo Fossa Vicentini wrote:
> With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link
> state change") we are now able to detect when the carrier is properly
> present in the device, so only report an unexpected unknown speed when it
> is properly detected. Unknown speed is expected to be seen by the device
> in case the backing device has no link detected.
>
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Murilo Fossa Vicentini <muvic@linux.ibm.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-20 0:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-16 14:50 [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present Murilo Fossa Vicentini
2019-09-16 15:21 ` Thomas Falcon
2019-09-20 0:37 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox