From: David Miller <davem@davemloft.net>
To: luke.w.hsiao@gmail.com
Cc: netdev@vger.kernel.org, axboe@kernel.dk, kuba@kernel.org,
lukehsiao@google.com, soheil@google.com, arjunroy@google.com,
edumazet@google.com, jannh@google.com
Subject: Re: [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock()
Date: Mon, 24 Aug 2020 16:16:41 -0700 (PDT) [thread overview]
Message-ID: <20200824.161641.333865613724287036.davem@davemloft.net> (raw)
In-Reply-To: <20200822044105.3097613-1-luke.w.hsiao@gmail.com>
From: Luke Hsiao <luke.w.hsiao@gmail.com>
Date: Fri, 21 Aug 2020 21:41:04 -0700
> From: Luke Hsiao <lukehsiao@google.com>
>
> For TCP tx zero-copy, the kernel notifies the process of completions by
> queuing completion notifications on the socket error queue. This patch
> allows reading these notifications via recvmsg to support TCP tx
> zero-copy.
>
> Ancillary data was originally disallowed due to privilege escalation
> via io_uring's offloading of sendmsg() onto a kernel thread with kernel
> credentials (https://crbug.com/project-zero/1975). So, we must ensure
> that the socket type is one where the ancillary data types that are
> delivered on recvmsg are plain data (no file descriptors or values that
> are translated based on the identity of the calling process).
>
> This was tested by using io_uring to call recvmsg on the MSG_ERRQUEUE
> with tx zero-copy enabled. Before this patch, we received -EINVALID from
> this specific code path. After this patch, we could read tcp tx
> zero-copy completion notifications from the MSG_ERRQUEUE.
Would be great to see such test programs added to selftests instead of
vaguely being described.
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Signed-off-by: Arjun Roy <arjunroy@google.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Jann Horn <jannh@google.com>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Luke Hsiao <lukehsiao@google.com>
Applied.
prev parent reply other threads:[~2020-08-24 23:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 23:49 [PATCH net-next 0/2] Support reading msg errq from io_uring Luke Hsiao
2020-08-20 23:49 ` [PATCH net-next 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-21 21:10 ` Jens Axboe
2020-08-20 23:49 ` [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-21 20:41 ` Jakub Kicinski
2020-08-21 21:11 ` Jens Axboe
2020-08-22 0:08 ` Luke Hsiao
2020-08-22 1:17 ` Jens Axboe
2020-08-22 2:04 ` [PATCH net-next v2 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-22 2:04 ` [PATCH net-next v2 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-22 2:08 ` Jens Axboe
2020-08-22 2:13 ` Luke Hsiao
2020-08-22 2:16 ` Jens Axboe
2020-08-22 4:41 ` [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-22 4:41 ` [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-22 15:49 ` Jens Axboe
2020-08-24 23:16 ` David Miller
2020-08-24 23:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824.161641.333865613724287036.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjunroy@google.com \
--cc=axboe@kernel.dk \
--cc=edumazet@google.com \
--cc=jannh@google.com \
--cc=kuba@kernel.org \
--cc=luke.w.hsiao@gmail.com \
--cc=lukehsiao@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox