Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: luke.w.hsiao@gmail.com
Cc: netdev@vger.kernel.org, axboe@kernel.dk, kuba@kernel.org,
	lukehsiao@google.com, arjunroy@google.com, soheil@google.com,
	edumazet@google.com
Subject: Re: [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE
Date: Mon, 24 Aug 2020 16:16:55 -0700 (PDT)	[thread overview]
Message-ID: <20200824.161655.863789085344308332.davem@davemloft.net> (raw)
In-Reply-To: <20200822044105.3097613-2-luke.w.hsiao@gmail.com>

From: Luke Hsiao <luke.w.hsiao@gmail.com>
Date: Fri, 21 Aug 2020 21:41:05 -0700

> From: Luke Hsiao <lukehsiao@google.com>
> 
> Currently, io_uring's recvmsg subscribes to both POLLERR and POLLIN. In
> the context of TCP tx zero-copy, this is inefficient since we are only
> reading the error queue and not using recvmsg to read POLLIN responses.
> 
> This patch was tested by using a simple sending program to call recvmsg
> using io_uring with MSG_ERRQUEUE set and verifying with printks that the
> POLLIN is correctly unset when the msg flags are MSG_ERRQUEUE.

Again, selftests additions please.

> Signed-off-by: Arjun Roy <arjunroy@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Luke Hsiao <lukehsiao@google.com>

Applied.

  parent reply	other threads:[~2020-08-24 23:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 23:49 [PATCH net-next 0/2] Support reading msg errq from io_uring Luke Hsiao
2020-08-20 23:49 ` [PATCH net-next 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-21 21:10   ` Jens Axboe
2020-08-20 23:49 ` [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-21 20:41   ` Jakub Kicinski
2020-08-21 21:11     ` Jens Axboe
2020-08-22  0:08       ` Luke Hsiao
2020-08-22  1:17         ` Jens Axboe
2020-08-22  2:04           ` [PATCH net-next v2 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-22  2:04             ` [PATCH net-next v2 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-22  2:08               ` Jens Axboe
2020-08-22  2:13                 ` Luke Hsiao
2020-08-22  2:16                   ` Jens Axboe
2020-08-22  4:41                     ` [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-22  4:41                       ` [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-22 15:49                         ` Jens Axboe
2020-08-24 23:16                         ` David Miller [this message]
2020-08-24 23:16                       ` [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824.161655.863789085344308332.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arjunroy@google.com \
    --cc=axboe@kernel.dk \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=luke.w.hsiao@gmail.com \
    --cc=lukehsiao@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soheil@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox