From: Jens Axboe <axboe@kernel.dk>
To: Luke Hsiao <lukehsiao@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Luke Hsiao <luke.w.hsiao@gmail.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Arjun Roy <arjunroy@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE
Date: Fri, 21 Aug 2020 19:17:46 -0600 [thread overview]
Message-ID: <9abca73b-de63-f69d-caff-ae3ed24854de@kernel.dk> (raw)
In-Reply-To: <CADFWnLzwUjs7Sw98y0vitTyPxCzsopeYKO0bVdG9r4uG7qBg2g@mail.gmail.com>
On 8/21/20 6:08 PM, Luke Hsiao wrote:
> Hi Jakub and Jens,
>
> Thank you for both of your reviews. Some responses inline below.
>
> On Fri, Aug 21, 2020 at 2:11 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/21/20 2:41 PM, Jakub Kicinski wrote:
>>> On Thu, 20 Aug 2020 16:49:54 -0700 Luke Hsiao wrote:
>>>> + /* If reading from MSG_ERRQUEUE using recvmsg, ignore POLLIN */
>>>> + if (req->opcode == IORING_OP_RECVMSG && (sqe->msg_flags & MSG_ERRQUEUE))
>>>> + mask &= ~(POLLIN);
>>>
>>> FWIW this adds another W=1 C=1 warnings to this code:
>>>
>>> fs/io_uring.c:4940:22: warning: invalid assignment: &=
>>> fs/io_uring.c:4940:22: left side has type restricted __poll_t
>>> fs/io_uring.c:4940:22: right side has type int
>>
>> Well, 8 or 9 of them don't really matter... This is something that should
>> be cleaned up separately at some point.
>
> In the spirit of not adding a warning, even if it doesn't really
> matter, I'd like to fix this. But, I'm struggling to reproduce these
> warnings using upstream net-next and make for x86_64. With my patches
> on top of net-next/master, I'm running
>
> $ make defconfig
> $ make -j`nproc` W=1
>
> I don't see the warning you mentioned in the logs. Could you tell me
> how I can repro this warning?
You should see them with C=1. But as I said, don't worry about it, as that's
a class of warnings and several exist already. It needs to get cleaned up
separately.
>>> And obviously the brackets around POLLIN are not necessary.
>>
>> Agree, would be cleaner without!
>
> Thanks, I'll also remove these unnecessary parens in v2 of the patch series.
Please do, thanks!
--
Jens Axboe
next prev parent reply other threads:[~2020-08-22 1:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 23:49 [PATCH net-next 0/2] Support reading msg errq from io_uring Luke Hsiao
2020-08-20 23:49 ` [PATCH net-next 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-21 21:10 ` Jens Axboe
2020-08-20 23:49 ` [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-21 20:41 ` Jakub Kicinski
2020-08-21 21:11 ` Jens Axboe
2020-08-22 0:08 ` Luke Hsiao
2020-08-22 1:17 ` Jens Axboe [this message]
2020-08-22 2:04 ` [PATCH net-next v2 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-22 2:04 ` [PATCH net-next v2 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-22 2:08 ` Jens Axboe
2020-08-22 2:13 ` Luke Hsiao
2020-08-22 2:16 ` Jens Axboe
2020-08-22 4:41 ` [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() Luke Hsiao
2020-08-22 4:41 ` [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Luke Hsiao
2020-08-22 15:49 ` Jens Axboe
2020-08-24 23:16 ` David Miller
2020-08-24 23:16 ` [PATCH net-next v3 1/2] io_uring: allow tcp ancillary data for __sys_recvmsg_sock() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abca73b-de63-f69d-caff-ae3ed24854de@kernel.dk \
--to=axboe@kernel.dk \
--cc=arjunroy@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=luke.w.hsiao@gmail.com \
--cc=lukehsiao@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox