* [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers
@ 2021-10-12 2:32 Wan Jiabing
2021-10-18 16:06 ` John Fastabend
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-10-12 2:32 UTC (permalink / raw)
To: Shuah Khan, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, linux-kselftest, netdev, bpf, linux-kernel
Cc: kael_w, Wan Jiabing
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Fix the commit description.
---
tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 8fcd44841bb2..9d59c3990ca8 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -11,7 +11,6 @@
#include <fcntl.h>
#include <unistd.h>
#include <ftw.h>
-#include <unistd.h>
#include "cgroup_helpers.h"
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers
2021-10-12 2:32 [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers Wan Jiabing
@ 2021-10-18 16:06 ` John Fastabend
2021-10-20 17:46 ` Andrii Nakryiko
0 siblings, 1 reply; 3+ messages in thread
From: John Fastabend @ 2021-10-18 16:06 UTC (permalink / raw)
To: Wan Jiabing, Shuah Khan, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, linux-kselftest, netdev, bpf,
linux-kernel
Cc: kael_w, Wan Jiabing
Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> than once.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Fix the commit description.
> ---
The Subject is a bit unusual. Typically it would be something like,
"[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
For the actual patch though LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers
2021-10-18 16:06 ` John Fastabend
@ 2021-10-20 17:46 ` Andrii Nakryiko
0 siblings, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2021-10-20 17:46 UTC (permalink / raw)
To: John Fastabend
Cc: Wan Jiabing, Shuah Khan, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
KP Singh, open list:KERNEL SELFTEST FRAMEWORK, Networking, bpf,
open list, kael_w
On Mon, Oct 18, 2021 at 9:07 AM John Fastabend <john.fastabend@gmail.com> wrote:
>
> Wan Jiabing wrote:
> > Fix following checkincludes.pl warning:
> > ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> > tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> > than once.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> > ---
> > Changelog:
> > v2:
> > - Fix the commit description.
> > ---
>
> The Subject is a bit unusual. Typically it would be something like,
>
> "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.
>
> For the actual patch though LGTM.
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-20 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 2:32 [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers Wan Jiabing
2021-10-18 16:06 ` John Fastabend
2021-10-20 17:46 ` Andrii Nakryiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox