From: Vladimir Oltean <olteanv@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
Frank Wunderlich <frank-w@public-files.de>,
netdev <netdev@vger.kernel.org>,
erkin.bozoglu@xeront.com
Subject: Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run twice
Date: Sat, 15 Apr 2023 13:12:34 +0300 [thread overview]
Message-ID: <20230415101234.rmo3b27iv3p5o42l@skbuf> (raw)
In-Reply-To: <896514df-af33-6408-8b33-d8fd06e671ef@arinc9.com>
On Sat, Apr 15, 2023 at 01:41:07AM +0300, Arınç ÜNAL wrote:
> I moved enabling the regulators from mt7530_setup() to mt7530_probe().
> Enabling the regulators there ends up with exception warnings on the
> first time.
Have you read what the WARN_ON() in _regulator_put() has to say?
/* Docs say you must disable before calling regulator_put() */
WARN_ON(regulator->enable_count);
If you call regulator_enable() during probe, do you also call
regulator_disable() during the probe error path?
prev parent reply other threads:[~2023-04-15 10:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 22:41 mt7530: dsa_switch_parse_of() fails, causes probe code to run twice Arınç ÜNAL
2023-04-14 22:48 ` Daniel Golle
2023-04-14 23:23 ` Arınç ÜNAL
2023-04-14 23:53 ` Daniel Golle
2023-04-15 0:28 ` Arınç ÜNAL
2023-04-15 0:52 ` Daniel Golle
2023-04-15 7:53 ` Arınç ÜNAL
2023-04-15 9:43 ` Arınç ÜNAL
2023-04-15 12:43 ` Daniel Golle
2023-04-15 13:19 ` Arınç ÜNAL
2023-04-15 13:38 ` Vladimir Oltean
2023-04-15 13:40 ` Arınç ÜNAL
2023-04-15 13:46 ` Vladimir Oltean
2023-04-15 14:02 ` Daniel Golle
2023-04-15 14:20 ` Vladimir Oltean
2023-04-15 14:28 ` Vladimir Oltean
2023-04-15 14:57 ` Arınç ÜNAL
2023-04-16 9:38 ` Arınç ÜNAL
2023-04-16 11:57 ` Daniel Golle
2023-04-15 10:12 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230415101234.rmo3b27iv3p5o42l@skbuf \
--to=olteanv@gmail.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=erkin.bozoglu@xeront.com \
--cc=frank-w@public-files.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox