From: Vladimir Oltean <olteanv@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
Frank Wunderlich <frank-w@public-files.de>,
netdev <netdev@vger.kernel.org>,
erkin.bozoglu@xeront.com, Thibaut <hacks@slashdirt.org>
Subject: Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run twice
Date: Sat, 15 Apr 2023 16:46:04 +0300 [thread overview]
Message-ID: <20230415134604.2mw3iodnrd2savs3@skbuf> (raw)
In-Reply-To: <5f7d58ba-60c8-f635-a06d-a041588f64da@arinc9.com>
On Sat, Apr 15, 2023 at 04:40:19PM +0300, Arınç ÜNAL wrote:
> My wording was not great there. What I meant is that PHY muxing will be
> configured before dsa_register_switch() is run.
And we're back to the discussion from the thread "Move MT7530 phy muxing
from DSA to PHY driver". What if someone decides that they don't need
the switch driver - can they disable it? No.
Your thoughts are stopping mid way. If you think that PHY muxing should
work without registering the DSA switch, then it doesn't belong in the
DSA driver, plain and simple. No "yeah, but I can move it here, and it
could kinda work, as a side effect of a driver failing to probe, or
probing successfully but not registering with the subsystems for its
primary purpose, or ...".
next prev parent reply other threads:[~2023-04-15 13:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 22:41 mt7530: dsa_switch_parse_of() fails, causes probe code to run twice Arınç ÜNAL
2023-04-14 22:48 ` Daniel Golle
2023-04-14 23:23 ` Arınç ÜNAL
2023-04-14 23:53 ` Daniel Golle
2023-04-15 0:28 ` Arınç ÜNAL
2023-04-15 0:52 ` Daniel Golle
2023-04-15 7:53 ` Arınç ÜNAL
2023-04-15 9:43 ` Arınç ÜNAL
2023-04-15 12:43 ` Daniel Golle
2023-04-15 13:19 ` Arınç ÜNAL
2023-04-15 13:38 ` Vladimir Oltean
2023-04-15 13:40 ` Arınç ÜNAL
2023-04-15 13:46 ` Vladimir Oltean [this message]
2023-04-15 14:02 ` Daniel Golle
2023-04-15 14:20 ` Vladimir Oltean
2023-04-15 14:28 ` Vladimir Oltean
2023-04-15 14:57 ` Arınç ÜNAL
2023-04-16 9:38 ` Arınç ÜNAL
2023-04-16 11:57 ` Daniel Golle
2023-04-15 10:12 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230415134604.2mw3iodnrd2savs3@skbuf \
--to=olteanv@gmail.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=erkin.bozoglu@xeront.com \
--cc=frank-w@public-files.de \
--cc=hacks@slashdirt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox