From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Steven Rostedt <rostedt@goodmis.org>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 0/2] DSA trace events
Date: Fri, 21 Apr 2023 15:47:08 +0300 [thread overview]
Message-ID: <20230421124708.tznoutsymiirqja2@skbuf> (raw)
In-Reply-To: <20230421213850.5ca0b347e99831e534b79fe7@kernel.org>
On Fri, Apr 21, 2023 at 09:38:50PM +0900, Masami Hiramatsu wrote:
> If the subsystem maintainers are OK for including this, it is OK.
> But basically, since the event is exposed to userland and you may keep
> these events maintained, you should carefully add the events.
> If those are only for debugging (after debug, it will not be used
> frequently), can you consider to use kprobe events?
> 'perf probe' command will also help you to trace local variables and
> structure members as like gdb does.
Thanks for taking a look. I haven't looked at kprobe events. I also
wasn't planning on maintaining these assuming stable UABI terms, just
for debugging. What are some user space consumers that expect the UABI
to be stable, and what is it about the trace events that can/can't change?
next prev parent reply other threads:[~2023-04-21 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 14:14 [PATCH net-next 0/2] DSA trace events Vladimir Oltean
2023-04-07 14:14 ` [PATCH net-next 1/2] net: dsa: add trace points for FDB/MDB operations Vladimir Oltean
2023-04-07 14:14 ` [PATCH net-next 2/2] net: dsa: add trace points for VLAN operations Vladimir Oltean
2023-04-12 0:48 ` [PATCH net-next 0/2] DSA trace events Andrew Lunn
2023-04-12 9:55 ` Vladimir Oltean
2023-04-21 12:38 ` Masami Hiramatsu
2023-04-21 12:47 ` Vladimir Oltean [this message]
2023-04-24 22:25 ` Steven Rostedt
2023-04-26 19:13 ` Vladimir Oltean
2023-04-26 19:23 ` Steven Rostedt
2023-04-26 19:43 ` Vladimir Oltean
2023-04-26 19:47 ` Steven Rostedt
2023-04-26 21:07 ` Vladimir Oltean
2023-04-27 0:33 ` Andrew Lunn
2023-04-12 8:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421124708.tznoutsymiirqja2@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox