From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 0/2] DSA trace events
Date: Thu, 27 Apr 2023 00:07:50 +0300 [thread overview]
Message-ID: <20230426210750.tonhsstc4xhrzd3c@skbuf> (raw)
In-Reply-To: <20230426154713.6706865f@gandalf.local.home>
On Wed, Apr 26, 2023 at 03:47:13PM -0400, Steven Rostedt wrote:
> I also want to add that if a tool does use a trace event that was not your
> intention, you can then fix the tool to do it properly.
>
> I had this with powertop. It had hardcoded events (did not use
> libtraceevent) and when I modified the layout, it broke, and Linus reverted
> my changes. After fixing powertop to do things properly, I was able to get
> my changes back in.
>
> So even if you do break user space, you can still fix it later.
Thanks, this is helpful.
next prev parent reply other threads:[~2023-04-26 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 14:14 [PATCH net-next 0/2] DSA trace events Vladimir Oltean
2023-04-07 14:14 ` [PATCH net-next 1/2] net: dsa: add trace points for FDB/MDB operations Vladimir Oltean
2023-04-07 14:14 ` [PATCH net-next 2/2] net: dsa: add trace points for VLAN operations Vladimir Oltean
2023-04-12 0:48 ` [PATCH net-next 0/2] DSA trace events Andrew Lunn
2023-04-12 9:55 ` Vladimir Oltean
2023-04-21 12:38 ` Masami Hiramatsu
2023-04-21 12:47 ` Vladimir Oltean
2023-04-24 22:25 ` Steven Rostedt
2023-04-26 19:13 ` Vladimir Oltean
2023-04-26 19:23 ` Steven Rostedt
2023-04-26 19:43 ` Vladimir Oltean
2023-04-26 19:47 ` Steven Rostedt
2023-04-26 21:07 ` Vladimir Oltean [this message]
2023-04-27 0:33 ` Andrew Lunn
2023-04-12 8:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426210750.tonhsstc4xhrzd3c@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox