[PATCH net-next 0/5] Improve the taprio qdisc's relationship with its children

[PATCH net-next 0/5] Improve the taprio qdisc's relationship with its children

[Vladimir Oltean]

Has anyone received this message? I guess at least vger and kuba@kernel.org
rejected it, because I got this bounce email:

kernel.org suspects your message is spam and rejected it.

Error:
550 5.7.350 Remote server returned message detected as spam -> 554 5.7.1
Service unavailable; Helo command [EUR04-DB3-obe.outbound.protection.outlook.com]
blocked using dbl.spamhaus.org; Error: open resolver;
https://www.spamhaus.org/returnc/pub/34.216.226.155

Message rejected by: smtp.kernel.org

Interestingly, if I click the link above, it says "This is not due to an
issue with your email set-up", so I'm not sure what to believe...

----- Forwarded message from Vladimir Oltean <vladimir.oltean@nxp.com> -----

Date: Wed, 31 May 2023 20:39:23 +0300
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Jamal Hadi Salim <jhs@mojatatu.com>, Cong Wang
 <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Vinicius Costa
 Gomes <vinicius.gomes@intel.com>, linux-kernel@vger.kernel.org,
 intel-wired-lan@lists.osuosl.org, Muhammad Husaini Zulkifli
 <muhammad.husaini.zulkifli@intel.com>, Peilin Ye <yepeilin.cs@gmail.com>,
 Pedro Tammela <pctammela@mojatatu.com>
Subject: [PATCH net-next 0/5] Improve the taprio qdisc's relationship with
 its children
X-Mailer: git-send-email 2.34.1

Prompted by Vinicius' request to consolidate some child Qdisc
dereferences in taprio:
https://lore.kernel.org/netdev/87edmxv7x2.fsf@intel.com/

I remembered that I had left some unfinished work in this Qdisc, namely
commit af7b29b1deaa ("Revert "net/sched: taprio: make qdisc_leaf() see
the per-netdev-queue pfifo child qdiscs"").

This patch set represents another stab at, essentially, what's in the
title. Not only does taprio not properly detect when it's grafted as a
non-root qdisc, but it also returns incorrect per-class stats.
Eventually, Vinicius' request is addressed too, although in a different
form than the one he requested (which was purely cosmetic).

Review from people more experienced with Qdiscs than me would be
appreciated. I tried my best to explain what I consider to be problems.
I am deliberately targeting net-next because the changes are too
invasive for net - they were reverted from stable once already.

Vladimir Oltean (5):
  net/sched: taprio: don't access q->qdiscs[] in unoffloaded mode during
    attach()
  net/sched: taprio: keep child Qdisc refcount elevated at 2 in offload
    mode
  net/sched: taprio: try again to report q->qdiscs[] to qdisc_leaf()
  net/sched: taprio: delete misleading comment about preallocating child
    qdiscs
  net/sched: taprio: dump class stats for the actual q->qdiscs[]

 net/sched/sch_taprio.c | 60 ++++++++++++++++++++++++------------------
 1 file changed, 35 insertions(+), 25 deletions(-)

-- 
2.34.1


----- End forwarded message -----

Failed delivery to smtp.kernel.org: blocked using dbl.spamhaus.org; Error: open resolver; (was: [Intel-wired-lan] [PATCH net-next 0/5] Improve the taprio qdisc's relationship with its children)

[Paul Menzel]

[Cc: postmaster@kernel.org]


Dear Vladimir,


I have not seen this message. Maybe the postmasters know more.


Kind regards,

Paul


Am 31.05.23 um 20:33 schrieb Vladimir Oltean:
> Has anyone received this message? I guess at least vger and kuba@kernel.org
> rejected it, because I got this bounce email:
> 
> kernel.org suspects your message is spam and rejected it.
> 
> Error:
> 550 5.7.350 Remote server returned message detected as spam -> 554 5.7.1
> Service unavailable; Helo command [EUR04-DB3-obe.outbound.protection.outlook.com]
> blocked using dbl.spamhaus.org; Error: open resolver;
> https://www.spamhaus.org/returnc/pub/34.216.226.155
> 
> Message rejected by: smtp.kernel.org
> 
> Interestingly, if I click the link above, it says "This is not due to an
> issue with your email set-up", so I'm not sure what to believe...
> 
> ----- Forwarded message from Vladimir Oltean <vladimir.oltean@nxp.com> -----
> 
> Date: Wed, 31 May 2023 20:39:23 +0300
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> To: netdev@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
>   <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
>   <pabeni@redhat.com>, Jamal Hadi Salim <jhs@mojatatu.com>, Cong Wang
>   <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Vinicius Costa
>   Gomes <vinicius.gomes@intel.com>, linux-kernel@vger.kernel.org,
>   intel-wired-lan@lists.osuosl.org, Muhammad Husaini Zulkifli
>   <muhammad.husaini.zulkifli@intel.com>, Peilin Ye <yepeilin.cs@gmail.com>,
>   Pedro Tammela <pctammela@mojatatu.com>
> Subject: [PATCH net-next 0/5] Improve the taprio qdisc's relationship with
>   its children
> X-Mailer: git-send-email 2.34.1
> 
> Prompted by Vinicius' request to consolidate some child Qdisc
> dereferences in taprio:
> https://lore.kernel.org/netdev/87edmxv7x2.fsf@intel.com/
> 
> I remembered that I had left some unfinished work in this Qdisc, namely
> commit af7b29b1deaa ("Revert "net/sched: taprio: make qdisc_leaf() see
> the per-netdev-queue pfifo child qdiscs"").
> 
> This patch set represents another stab at, essentially, what's in the
> title. Not only does taprio not properly detect when it's grafted as a
> non-root qdisc, but it also returns incorrect per-class stats.
> Eventually, Vinicius' request is addressed too, although in a different
> form than the one he requested (which was purely cosmetic).
> 
> Review from people more experienced with Qdiscs than me would be
> appreciated. I tried my best to explain what I consider to be problems.
> I am deliberately targeting net-next because the changes are too
> invasive for net - they were reverted from stable once already.
> 
> Vladimir Oltean (5):
>    net/sched: taprio: don't access q->qdiscs[] in unoffloaded mode during
>      attach()
>    net/sched: taprio: keep child Qdisc refcount elevated at 2 in offload
>      mode
>    net/sched: taprio: try again to report q->qdiscs[] to qdisc_leaf()
>    net/sched: taprio: delete misleading comment about preallocating child
>      qdiscs
>    net/sched: taprio: dump class stats for the actual q->qdiscs[]
> 
>   net/sched/sch_taprio.c | 60 ++++++++++++++++++++++++------------------
>   1 file changed, 35 insertions(+), 25 deletions(-)
>