From: Conor Dooley <conor@kernel.org>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
hkallweit1@gmail.com, linux@armlinux.org.uk, corbet@lwn.net,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode
Date: Thu, 16 Nov 2023 14:22:41 +0000 [thread overview]
Message-ID: <20231116-flier-washed-eb1a45481323@squawk> (raw)
In-Reply-To: <20231116112437.10578-3-quic_luoj@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]
On Thu, Nov 16, 2023 at 07:24:33PM +0800, Luo Jie wrote:
> Add the new interface mode 10g-qxgmii, which is similar to
> usxgmii but extend to 4 channels to support maximum of 4
> ports with the link speed 10M/100M/1G/2.5G.
>
> This patch is separated from Vladimir Oltean's previous patch
> <net: phy: introduce core support for phy-mode = "10g-qxgmii">.
This belongs in the changelog under the --- line.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Are you missing a from: line in this patch?
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index d14d123ad7a0..0ef6103c5fd8 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -104,6 +104,7 @@ properties:
> - usxgmii
> - 10gbase-r
> - 25gbase-r
> + - 10g-qxgmii
>
> phy-mode:
> $ref: "#/properties/phy-connection-type"
> --
> 2.42.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-16 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 11:24 [PATCH v4 0/6] add qca8084 ethernet phy driver Luo Jie
2023-11-16 11:24 ` [PATCH v4 1/6] net: phy: introduce core support for phy-mode = "10g-qxgmii" Luo Jie
2023-11-16 11:24 ` [PATCH v4 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode Luo Jie
2023-11-16 14:22 ` Conor Dooley [this message]
2023-11-16 18:12 ` Andrew Lunn
2023-11-17 9:45 ` Jie Luo
2023-11-17 9:44 ` Jie Luo
2023-11-16 11:24 ` [PATCH v4 3/6] net: phy: at803x: add QCA8084 ethernet phy support Luo Jie
2023-11-16 11:24 ` [PATCH v4 4/6] net: phy: at803x: add the function phydev_id_is_qca808x Luo Jie
2023-11-16 11:24 ` [PATCH v4 5/6] net: phy: at803x: Add qca8084_config_init function Luo Jie
2023-11-16 11:24 ` [PATCH v4 6/6] net: phy: qca8084: add qca8084_link_change_notify Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116-flier-washed-eb1a45481323@squawk \
--to=conor@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_luoj@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox