From: Tobias Waldekranz <tobias@waldekranz.com>
To: stephen@networkplumber.org, dsahern@kernel.org
Cc: liuhangbin@gmail.com, netdev@vger.kernel.org
Subject: [PATCH iproute2 2/3] bridge: vlan: Add support for setting a VLANs MSTI
Date: Fri, 14 Jun 2024 15:38:17 +0200 [thread overview]
Message-ID: <20240614133818.14876-3-tobias@waldekranz.com> (raw)
In-Reply-To: <20240614133818.14876-1-tobias@waldekranz.com>
Allow the user to associate one or more VLANs with a multiple spanning
tree instance (MSTI), when MST is enabled on the bridge.
Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
---
bridge/vlan.c | 13 +++++++++++++
man/man8/bridge.8 | 9 ++++++++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/bridge/vlan.c b/bridge/vlan.c
index 0a7e6c45..34d7f767 100644
--- a/bridge/vlan.c
+++ b/bridge/vlan.c
@@ -56,6 +56,7 @@ static void usage(void)
" [ mcast_querier_interval QUERIER_INTERVAL ]\n"
" [ mcast_query_interval QUERY_INTERVAL ]\n"
" [ mcast_query_response_interval QUERY_RESPONSE_INTERVAL ]\n"
+ " [ msti MSTI ]\n"
" bridge vlan global { show } [ dev DEV ] [ vid VLAN_ID ]\n");
exit(-1);
}
@@ -406,6 +407,7 @@ static int vlan_global_option_set(int argc, char **argv)
short vid = -1;
__u64 val64;
__u32 val32;
+ __u16 val16;
__u8 val8;
afspec = addattr_nest(&req.n, sizeof(req),
@@ -536,6 +538,12 @@ static int vlan_global_option_set(int argc, char **argv)
addattr64(&req.n, 1024,
BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_INTVL,
val64);
+ } else if (strcmp(*argv, "msti") == 0) {
+ NEXT_ARG();
+ if (get_u16(&val16, *argv, 0))
+ invarg("invalid msti", *argv);
+ addattr16(&req.n, 1024,
+ BRIDGE_VLANDB_GOPTS_MSTI, val16);
} else {
if (strcmp(*argv, "help") == 0)
NEXT_ARG();
@@ -945,6 +953,11 @@ static void print_vlan_global_opts(struct rtattr *a, int ifindex)
"mcast_query_response_interval %llu ",
rta_getattr_u64(vattr));
}
+ if (vtb[BRIDGE_VLANDB_GOPTS_MSTI]) {
+ vattr = vtb[BRIDGE_VLANDB_GOPTS_MSTI];
+ print_uint(PRINT_ANY, "msti", "msti %u ",
+ rta_getattr_u16(vattr));
+ }
print_nl();
if (vtb[BRIDGE_VLANDB_GOPTS_MCAST_ROUTER_PORTS]) {
vattr = RTA_DATA(vtb[BRIDGE_VLANDB_GOPTS_MCAST_ROUTER_PORTS]);
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index bb02bd27..b4699801 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -266,7 +266,9 @@ bridge \- show / manipulate bridge addresses and devices
.B mcast_query_interval
.IR QUERY_INTERVAL " ] [ "
.B mcast_query_response_interval
-.IR QUERY_RESPONSE_INTERVAL " ]"
+.IR QUERY_RESPONSE_INTERVAL " ] [ "
+.B msti
+.IR MSTI " ]"
.ti -8
.BR "bridge vlan global" " [ " show " ] [ "
@@ -1493,6 +1495,11 @@ startup phase.
set the Max Response Time/Maximum Response Delay for IGMP/MLD
queries sent by the bridge.
+.TP
+.BI msti " MSTI "
+associate the VLAN with the specified multiple spanning tree instance
+(MSTI).
+
.SS bridge vlan global show - list global vlan options.
This command displays the global VLAN options for each VLAN entry.
--
2.34.1
next prev parent reply other threads:[~2024-06-14 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 13:38 [PATCH iproute2 0/3] Multiple Spanning Tree (MST) Support Tobias Waldekranz
2024-06-14 13:38 ` [PATCH iproute2 1/3] ip: bridge: add support for mst_enabled Tobias Waldekranz
2024-06-19 3:02 ` Hangbin Liu
2024-06-14 13:38 ` Tobias Waldekranz [this message]
2024-06-14 13:38 ` [PATCH iproute2 3/3] bridge: mst: Add get/set support for MST states Tobias Waldekranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614133818.14876-3-tobias@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=dsahern@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox