public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: stephen@networkplumber.org, dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/3] ip: bridge: add support for mst_enabled
Date: Wed, 19 Jun 2024 11:02:16 +0800	[thread overview]
Message-ID: <ZnJKODji2Jgtsi2g@Laptop-X1> (raw)
In-Reply-To: <20240614133818.14876-2-tobias@waldekranz.com>

On Fri, Jun 14, 2024 at 03:38:16PM +0200, Tobias Waldekranz wrote:
> @@ -169,6 +170,18 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
>  				bm.optval |= no_ll_learn_bit;
>  			else
>  				bm.optval &= ~no_ll_learn_bit;
> +		} else if (matches(*argv, "mst_enabled") == 0) {
> +			__u32 mst_bit = 1 << BR_BOOLOPT_MST_ENABLE;
> +			__u8 mst_enabled;


Please use strcmp instead of match for new options.

Thanks
Hangbin

  reply	other threads:[~2024-06-19  3:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 13:38 [PATCH iproute2 0/3] Multiple Spanning Tree (MST) Support Tobias Waldekranz
2024-06-14 13:38 ` [PATCH iproute2 1/3] ip: bridge: add support for mst_enabled Tobias Waldekranz
2024-06-19  3:02   ` Hangbin Liu [this message]
2024-06-14 13:38 ` [PATCH iproute2 2/3] bridge: vlan: Add support for setting a VLANs MSTI Tobias Waldekranz
2024-06-14 13:38 ` [PATCH iproute2 3/3] bridge: mst: Add get/set support for MST states Tobias Waldekranz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnJKODji2Jgtsi2g@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=tobias@waldekranz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox