* [PATCH 0/2] ice: fix VF creation when !CONFIG_ICE_SWITCHDEV @ 2026-04-29 6:51 Vincent Chen 2026-04-29 6:51 ` [PATCH 1/2] ice: allow creating VFs " Vincent Chen 2026-04-29 6:51 ` [PATCH 2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf() Vincent Chen 0 siblings, 2 replies; 5+ messages in thread From: Vincent Chen @ 2026-04-29 6:51 UTC (permalink / raw) To: anthony.l.nguyen, przemyslaw.kitszel Cc: andrew+netdev, davem, edumazet, kuba, pabeni, intel-wired-lan, netdev, vincent.chen This patch series fixes an issue where VF creation fails when CONFIG_ICE_SWITCHDEV is disabled. When CONFIG_ICE_SWITCHDEV is disabled, the stub function ice_eswitch_attach_vf() returns -EOPNOTSUPP, causing VF initialization to fail even though basic VF functionality should work without switchdev support. The fix is split into two patches: 1. Add switchdev mode checks at caller sites to fix the immediate issue while maintaining backward compatibility. This ensures ice_eswitch_attach_vf() is only called when switchdev mode is enabled, consistent with how ice_eswitch_attach_sf() is handled. 2. Remove the now-redundant internal switchdev check from ice_eswitch_attach_vf(). Vincent Chen (2): ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV ice: remove redundant switchdev check in ice_eswitch_attach_vf() drivers/net/ethernet/intel/ice/ice_eswitch.c | 3 --- drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------ drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++- 3 files changed, 10 insertions(+), 10 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV 2026-04-29 6:51 [PATCH 0/2] ice: fix VF creation when !CONFIG_ICE_SWITCHDEV Vincent Chen @ 2026-04-29 6:51 ` Vincent Chen 2026-04-29 9:17 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-04-29 6:51 ` [PATCH 2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf() Vincent Chen 1 sibling, 1 reply; 5+ messages in thread From: Vincent Chen @ 2026-04-29 6:51 UTC (permalink / raw) To: anthony.l.nguyen, przemyslaw.kitszel Cc: andrew+netdev, davem, edumazet, kuba, pabeni, intel-wired-lan, netdev, vincent.chen Currently ice_eswitch_attach_vf() is called unconditionally in ice_start_vfs(), which causes VF creation to fail when CONFIG_ICE_SWITCHDEV is not defined. Fix this by adding switchdev mode checks at the call sites before calling ice_eswitch_attach_vf(), consistent with how ice_eswitch_attach_sf() is already handled in ice_devlink_port_new(). This is similar to commit aacca7a83b97 ("ice: allow creating VFs for !CONFIG_NET_SWITCHDEV") which fixed the same issue for the previous ice_eswitch_configure() API. Signed-off-by: Vincent Chen <vincent.chen@sifive.com> --- drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------ drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c b/drivers/net/ethernet/intel/ice/ice_sriov.c index 843e82fd3bf9..6a0b724e46f9 100644 --- a/drivers/net/ethernet/intel/ice/ice_sriov.c +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c @@ -484,12 +484,14 @@ static int ice_start_vfs(struct ice_pf *pf) goto teardown; } - retval = ice_eswitch_attach_vf(pf, vf); - if (retval) { - dev_err(ice_pf_to_dev(pf), "Failed to attach VF %d to eswitch, error %d", - vf->vf_id, retval); - ice_vf_vsi_release(vf); - goto teardown; + if (ice_is_eswitch_mode_switchdev(pf)) { + retval = ice_eswitch_attach_vf(pf, vf); + if (retval) { + dev_err(ice_pf_to_dev(pf), "Failed to attach VF %d to eswitch, error %d", + vf->vf_id, retval); + ice_vf_vsi_release(vf); + goto teardown; + } } set_bit(ICE_VF_STATE_INIT, vf->vf_states); diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c index de9e81ccee66..71595410174c 100644 --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c @@ -807,7 +807,8 @@ void ice_reset_all_vfs(struct ice_pf *pf) ice_vf_rebuild_vsi(vf); ice_vf_post_vsi_rebuild(vf); - ice_eswitch_attach_vf(pf, vf); + if (ice_is_eswitch_mode_switchdev(pf)) + ice_eswitch_attach_vf(pf, vf); mutex_unlock(&vf->cfg_lock); } -- 2.34.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV 2026-04-29 6:51 ` [PATCH 1/2] ice: allow creating VFs " Vincent Chen @ 2026-04-29 9:17 ` Loktionov, Aleksandr 0 siblings, 0 replies; 5+ messages in thread From: Loktionov, Aleksandr @ 2026-04-29 9:17 UTC (permalink / raw) To: Vincent Chen, Nguyen, Anthony L, Kitszel, Przemyslaw Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Vincent Chen via Intel-wired-lan > Sent: Wednesday, April 29, 2026 8:51 AM > To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com> > Cc: andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; vincent.chen@sifive.com > Subject: [Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when > !CONFIG_ICE_SWITCHDEV > > Currently ice_eswitch_attach_vf() is called unconditionally in > ice_start_vfs(), which causes VF creation to fail when > CONFIG_ICE_SWITCHDEV is not defined. > > Fix this by adding switchdev mode checks at the call sites before > calling ice_eswitch_attach_vf(), consistent with how > ice_eswitch_attach_sf() is already handled in ice_devlink_port_new(). > This is similar to commit aacca7a83b97 ("ice: allow creating VFs for > !CONFIG_NET_SWITCHDEV") which fixed the same issue for the previous > ice_eswitch_configure() API. > > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > --- > drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------ > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++- > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c > b/drivers/net/ethernet/intel/ice/ice_sriov.c > index 843e82fd3bf9..6a0b724e46f9 100644 > --- a/drivers/net/ethernet/intel/ice/ice_sriov.c > +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c > @@ -484,12 +484,14 @@ static int ice_start_vfs(struct ice_pf *pf) > goto teardown; > } > > - retval = ice_eswitch_attach_vf(pf, vf); > - if (retval) { > - dev_err(ice_pf_to_dev(pf), "Failed to attach VF > %d to eswitch, error %d", > - vf->vf_id, retval); > - ice_vf_vsi_release(vf); > - goto teardown; > + if (ice_is_eswitch_mode_switchdev(pf)) { > + retval = ice_eswitch_attach_vf(pf, vf); > + if (retval) { > + dev_err(ice_pf_to_dev(pf), "Failed to > attach VF %d to eswitch, error %d", > + vf->vf_id, retval); > + ice_vf_vsi_release(vf); > + goto teardown; > + } > } > > set_bit(ICE_VF_STATE_INIT, vf->vf_states); diff --git > a/drivers/net/ethernet/intel/ice/ice_vf_lib.c > b/drivers/net/ethernet/intel/ice/ice_vf_lib.c > index de9e81ccee66..71595410174c 100644 > --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c > +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c > @@ -807,7 +807,8 @@ void ice_reset_all_vfs(struct ice_pf *pf) > ice_vf_rebuild_vsi(vf); > ice_vf_post_vsi_rebuild(vf); > > - ice_eswitch_attach_vf(pf, vf); > + if (ice_is_eswitch_mode_switchdev(pf)) > + ice_eswitch_attach_vf(pf, vf); > > mutex_unlock(&vf->cfg_lock); > } > -- > 2.34.1 Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf() 2026-04-29 6:51 [PATCH 0/2] ice: fix VF creation when !CONFIG_ICE_SWITCHDEV Vincent Chen 2026-04-29 6:51 ` [PATCH 1/2] ice: allow creating VFs " Vincent Chen @ 2026-04-29 6:51 ` Vincent Chen 2026-04-29 9:18 ` [Intel-wired-lan] " Loktionov, Aleksandr 1 sibling, 1 reply; 5+ messages in thread From: Vincent Chen @ 2026-04-29 6:51 UTC (permalink / raw) To: anthony.l.nguyen, przemyslaw.kitszel Cc: andrew+netdev, davem, edumazet, kuba, pabeni, intel-wired-lan, netdev, vincent.chen All callers of ice_eswitch_attach_vf() check the switchdev mode before calling the function, the internal switchdev mode check in ice_eswitch_attach_vf() is redundant. Remove this check to align with the design pattern used for ice_eswitch_attach_sf(), where the caller is responsible for checking switchdev mode before attachment. Signed-off-by: Vincent Chen <vincent.chen@sifive.com> --- drivers/net/ethernet/intel/ice/ice_eswitch.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c index 2e4f0969035f..c709decb26d5 100644 --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c @@ -512,9 +512,6 @@ int ice_eswitch_attach_vf(struct ice_pf *pf, struct ice_vf *vf) struct ice_repr *repr; int err; - if (!ice_is_eswitch_mode_switchdev(pf)) - return 0; - repr = ice_repr_create_vf(vf); if (IS_ERR(repr)) return PTR_ERR(repr); -- 2.34.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [Intel-wired-lan] [PATCH 2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf() 2026-04-29 6:51 ` [PATCH 2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf() Vincent Chen @ 2026-04-29 9:18 ` Loktionov, Aleksandr 0 siblings, 0 replies; 5+ messages in thread From: Loktionov, Aleksandr @ 2026-04-29 9:18 UTC (permalink / raw) To: Vincent Chen, Nguyen, Anthony L, Kitszel, Przemyslaw Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Vincent Chen via Intel-wired-lan > Sent: Wednesday, April 29, 2026 8:51 AM > To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com> > Cc: andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; vincent.chen@sifive.com > Subject: [Intel-wired-lan] [PATCH 2/2] ice: remove redundant switchdev > check in ice_eswitch_attach_vf() > > All callers of ice_eswitch_attach_vf() check the switchdev mode before > calling the function, the internal switchdev mode check in > ice_eswitch_attach_vf() is redundant. Remove this check to align with > the design pattern used for ice_eswitch_attach_sf(), where the caller > is responsible for checking switchdev mode before attachment. > > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > --- > drivers/net/ethernet/intel/ice/ice_eswitch.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c > b/drivers/net/ethernet/intel/ice/ice_eswitch.c > index 2e4f0969035f..c709decb26d5 100644 > --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c > +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c > @@ -512,9 +512,6 @@ int ice_eswitch_attach_vf(struct ice_pf *pf, > struct ice_vf *vf) > struct ice_repr *repr; > int err; > > - if (!ice_is_eswitch_mode_switchdev(pf)) > - return 0; > - > repr = ice_repr_create_vf(vf); > if (IS_ERR(repr)) > return PTR_ERR(repr); > -- > 2.34.1 Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-29 9:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-04-29 6:51 [PATCH 0/2] ice: fix VF creation when !CONFIG_ICE_SWITCHDEV Vincent Chen 2026-04-29 6:51 ` [PATCH 1/2] ice: allow creating VFs " Vincent Chen 2026-04-29 9:17 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-04-29 6:51 ` [PATCH 2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf() Vincent Chen 2026-04-29 9:18 ` [Intel-wired-lan] " Loktionov, Aleksandr
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox