* [PATCH net-next] net: usb: mcs7830: fix typo in module description and clarify it
@ 2026-05-05 1:34 Ethan Nelson-Moore
2026-05-05 6:43 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-05-05 1:34 UTC (permalink / raw)
To: linux-usb, netdev
Cc: Ethan Nelson-Moore, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Andy Shevchenko, Vadim Fedorenko
The mcs7830 driver's MODULE_DESCRIPTION has an errant parenthesis
and does not indicate that the device is an Ethernet adapter. Remove
the parenthesis and improve the description.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/usb/mcs7830.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c
index d6698f30218d..161f021ed419 100644
--- a/drivers/net/usb/mcs7830.c
+++ b/drivers/net/usb/mcs7830.c
@@ -626,5 +626,5 @@ static struct usb_driver mcs7830_driver = {
module_usb_driver(mcs7830_driver);
-MODULE_DESCRIPTION("USB to network adapter MCS7830)");
+MODULE_DESCRIPTION("MCS7830 USB to Ethernet adapter driver");
MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: usb: mcs7830: fix typo in module description and clarify it
2026-05-05 1:34 [PATCH net-next] net: usb: mcs7830: fix typo in module description and clarify it Ethan Nelson-Moore
@ 2026-05-05 6:43 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-05-05 6:43 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: linux-usb, netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Vadim Fedorenko
On Mon, May 04, 2026 at 06:34:59PM -0700, Ethan Nelson-Moore wrote:
> The mcs7830 driver's MODULE_DESCRIPTION has an errant parenthesis
MODULE_DESCRIPTION()
> and does not indicate that the device is an Ethernet adapter. Remove
> the parenthesis and improve the description.
...
> -MODULE_DESCRIPTION("USB to network adapter MCS7830)");
> +MODULE_DESCRIPTION("MCS7830 USB to Ethernet adapter driver");
It's better to align this with the top comment
* MOSCHIP MCS7830 based (7730/7830/7832) USB 2.0 Ethernet Devices
Another option is to align to Kconfig help
tristate "MosChip MCS7830 based Ethernet adapters"
(ideally all three should be the same).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-05 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-05 1:34 [PATCH net-next] net: usb: mcs7830: fix typo in module description and clarify it Ethan Nelson-Moore
2026-05-05 6:43 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox